Unified @types/node on 22.19.17 and moved into the pnpm catalog#27889
Conversation
- six workspaces declared @types/node, drifted across 22.19.17 (4 ws) and 25.6.0 (2 ws) - pinned to 22.19.17 to match the Node 22.18.0 LTS that CI runs against; declaring types ahead of the actual runtime risks autocomplete suggesting APIs that throw at runtime - bumped apps/admin and ghost/parse-email-address from 25.6.0 down to 22.19.17; tsc --noEmit passes cleanly on both, confirming neither was using v25-only declarations - catalogized so future bumps land in one place and stay aligned with the runtime
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
WalkthroughThis pull request consolidates Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27889 +/- ##
=======================================
Coverage 73.80% 73.80%
=======================================
Files 1519 1519
Lines 128187 128187
Branches 15354 15354
=======================================
Hits 94613 94613
+ Misses 32642 32620 -22
- Partials 932 954 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Six workspaces declared `@types/node` at two different majors:
Pinned all six to 22.19.17 and moved the entry into the default catalog.
Why 22 (not 25)
Ghost CI runs Node 22.18.0 (LTS). `@types/node` should match the runtime — types ahead of runtime risk autocomplete suggesting APIs that throw at runtime, and tsc happily compiling code that fails at execution.
Verification
Why catalog
Six workspaces is well above the 3+ threshold; centralizing means future Node-version bumps update one entry instead of six, and prevents the same drift recurring.