Skip to content

Changed Renovate grouping to bump @tryghost/limit-service on its own#27916

Merged
ErisDS merged 1 commit into
mainfrom
renovate-isolate-limit-service
May 15, 2026
Merged

Changed Renovate grouping to bump @tryghost/limit-service on its own#27916
ErisDS merged 1 commit into
mainfrom
renovate-isolate-limit-service

Conversation

@ErisDS
Copy link
Copy Markdown
Member

@ErisDS ErisDS commented May 15, 2026

Summary

Splits @tryghost/limit-service out of the "TryGhost admin support packages" Renovate group so its version bumps come out as their own PR.

Why

Unlike the other packages in that group (color-utils, custom-fonts, members-csv, timezone-data), limit-service bumps are feature-tied: each new entry in its lib/config.js allowlist is paired with consuming BREAD-service / limit-helper code here in Ghost. We need the version bump to land as a reviewable, single-package PR so it can be coordinated with the consuming change (and so a flaky CI run on an unrelated admin-support bump doesn't block it).

No other behaviour changes — limit-service still respects the rest of the existing config (schedule, automerge windows, dashboard approval for majors, etc.).

Test plan

  • Renovate config-only change; no runtime impact.
  • Verify next Renovate run opens an isolated Update dependency @tryghost/limit-service PR rather than bundling it into the admin-support group.

🤖 Generated with Claude Code

- limit-service bumps are feature-tied: each new flag in `lib/config.js` is paired with BREAD/limit-helper code in this repo, so the version bump needs to land as its own reviewable PR
- riding in with unrelated admin-support package updates (`color-utils`, `members-csv`, etc.) made the dependency PR harder to reason about and harder to coordinate with the consuming change

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 19851175-f191-442e-a09b-7620dc3fe175

📥 Commits

Reviewing files that changed from the base of the PR and between 23048d2 and cf491fe.

📒 Files selected for processing (1)
  • .github/renovate.json5

Walkthrough

This pull request modifies the Renovate dependency management configuration to separate @tryghost/limit-service into its own dedicated package grouping rule. The change removes @tryghost/limit-service from the shared "TryGhost admin support packages" matchPackageNames list, which previously bundled it with @tryghost/members-csv and @tryghost/timezone-data. A new packageRules entry is added to match only @tryghost/limit-service, assigning it its own groupName for independent dependency update handling.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: isolating @tryghost/limit-service into its own Renovate grouping for independent version bumps.
Description check ✅ Passed The description provides relevant context explaining the rationale (feature-tied bumps), implementation details, and test plan, all directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch renovate-isolate-limit-service

Comment @coderabbitai help to get the list of available commands and usage tips.

@ErisDS ErisDS merged commit bff6493 into main May 15, 2026
21 checks passed
@ErisDS ErisDS deleted the renovate-isolate-limit-service branch May 15, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant