Skip to content

Removed stale secretlint entries from knip ignoreDependencies#27947

Merged
9larsons merged 1 commit into
mainfrom
cleanup-knip-secretlint-ignores
May 18, 2026
Merged

Removed stale secretlint entries from knip ignoreDependencies#27947
9larsons merged 1 commit into
mainfrom
cleanup-knip-secretlint-ignores

Conversation

@9larsons
Copy link
Copy Markdown
Contributor

Summary

knip flagged these entries as stale (Remove from ignoreDependencies configuration hints) — it now resolves secretlint and @secretlint/* through .secretlintrc.json discovery, so the explicit ignoreDependencies entries are no longer needed.

Test plan

  • pnpm knip no longer shows the configuration hints
  • secretlint and @secretlint/* are not flagged as unlisted/unused

knip flagged these as stale configuration hints — it now resolves
secretlint and @secretlint/* through .secretlintrc.json discovery,
so the explicit ignoreDependencies entries are no longer needed.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 55e943fb-4d58-4de8-ae31-71abbca5c358

📥 Commits

Reviewing files that changed from the base of the PR and between a629ffb and ce76731.

📒 Files selected for processing (1)
  • knip.json
💤 Files with no reviewable changes (1)
  • knip.json

Walkthrough

This pull request removes unused configuration from knip.json. The ignoreDependencies section and its associated entries (including a secretlint pattern and scoped package references) have been deleted, leaving the ignoreWorkspaces list as the final configuration block. The change reduces configuration overhead without altering any functional behavior.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: removal of stale secretlint entries from knip's ignoreDependencies configuration.
Description check ✅ Passed The description is directly related to the changeset, explaining why the entries were removed (stale per knip) and providing test evidence that the change works correctly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cleanup-knip-secretlint-ignores

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons merged commit bb2a5de into main May 18, 2026
42 checks passed
@9larsons 9larsons deleted the cleanup-knip-secretlint-ignores branch May 18, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant