Add socialweb account migration settings UI#27957
Merged
Merged
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis PR adds account alias management to the ActivityPub module. It introduces API contracts and methods ( Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/activitypub/package.json`:
- Line 3: The package.json version was incorrectly bumped only to a patch
release ("version": "3.1.24") despite introducing new features; update the
"version" field in apps/activitypub/package.json from 3.1.24 to 3.2.0 so the
package reflects a minor release for the added API methods, React Query hooks,
UI components and routes.
In `@apps/activitypub/src/api/activitypub.ts`:
- Around line 519-531: The methods addAccountAlias and removeAccountAlias
currently cast fetchJSON() results directly to AccountAliasesResponse even
though fetchJSON can return null for 202/204; update both functions
(addAccountAlias and removeAccountAlias) to check if json is null and if so
return a safe default AccountAliasesResponse (e.g. an object with aliases: []
and destination: null/empty) before casting/returning, otherwise return the
parsed json; reference fetchJSON to locate the call and AccountAliasesResponse
as the return type to ensure callers always receive a non-null structure.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f727546a-f143-473d-a3c7-180ee33603ff
📒 Files selected for processing (8)
apps/activitypub/package.jsonapps/activitypub/src/api/activitypub.test.tsapps/activitypub/src/api/activitypub.tsapps/activitypub/src/hooks/use-activity-pub-queries.tsapps/activitypub/src/routes.tsxapps/activitypub/src/views/preferences/components/mastodon-migration.tsxapps/activitypub/src/views/preferences/components/settings.tsxapps/activitypub/test/acceptance/preferences.test.ts
JohnONolan
force-pushed
the
codex/mastodon-migration-ui
branch
from
67c4a32 to
46f1345
Compare
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
apps/activitypub/package.json (1)
3-3:⚠️ Potential issue | 🟠 Major | ⚡ Quick winBump version to 3.2.0 for this feature release.
The version was bumped to
3.1.25(PATCH increment), but this PR introduces new features: API methods for account aliases, React Query hooks, a preferences UI route and component, settings integration, and acceptance tests. Per the project's versioning policy, patch increments are reserved for bug fixes, while minor increments should be used for new feature releases. Bump to3.2.0instead.📦 Proposed fix
- "version": "3.1.25", + "version": "3.2.0",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/activitypub/package.json` at line 3, Update the package.json version from "3.1.25" to "3.2.0" to reflect the new feature release; locate the "version" field in apps/activitypub's package.json and change its value to 3.2.0 so the release semantics match the added API methods, React Query hooks, preferences UI/route, settings integration, and acceptance tests.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@apps/activitypub/package.json`:
- Line 3: Update the package.json version from "3.1.25" to "3.2.0" to reflect
the new feature release; locate the "version" field in apps/activitypub's
package.json and change its value to 3.2.0 so the release semantics match the
added API methods, React Query hooks, preferences UI/route, settings
integration, and acceptance tests.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bfe66a19-3662-41d3-8eff-29b71705d869
📒 Files selected for processing (8)
apps/activitypub/package.jsonapps/activitypub/src/api/activitypub.test.tsapps/activitypub/src/api/activitypub.tsapps/activitypub/src/hooks/use-activity-pub-queries.tsapps/activitypub/src/routes.tsxapps/activitypub/src/views/preferences/components/mastodon-migration.tsxapps/activitypub/src/views/preferences/components/settings.tsxapps/activitypub/test/acceptance/preferences.test.ts
🚧 Files skipped from review as they are similar to previous changes (7)
- apps/activitypub/src/views/preferences/components/settings.tsx
- apps/activitypub/src/api/activitypub.ts
- apps/activitypub/src/routes.tsx
- apps/activitypub/test/acceptance/preferences.test.ts
- apps/activitypub/src/api/activitypub.test.ts
- apps/activitypub/src/hooks/use-activity-pub-queries.ts
- apps/activitypub/src/views/preferences/components/mastodon-migration.tsx
JohnONolan
force-pushed
the
codex/mastodon-migration-ui
branch
from
46f1345 to
c5ad5c1
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/activitypub/src/views/preferences/components/mastodon-migration.tsx`:
- Around line 60-61: The unlink failure is being stored in handleError (useState
handleError / setHandleError), which incorrectly marks the input invalid and
shows a field-level message; introduce a dedicated state (e.g., aliasActionError
and setAliasActionError) and use that for alias/unlink action errors instead of
handleError; update the unlink/remove flow (where setHandleError is currently
called around the removingAlias logic) to call setAliasActionError on failure
and clear it on success, and ensure the input validation and rendering logic
(the code that checks handleError to set input invalid and to render the
field-level message) continue to only reference handleError so only validation
errors affect the input UI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d91537da-f19e-40ce-83d2-604cfd6338fb
📒 Files selected for processing (8)
apps/activitypub/package.jsonapps/activitypub/src/api/activitypub.test.tsapps/activitypub/src/api/activitypub.tsapps/activitypub/src/hooks/use-activity-pub-queries.tsapps/activitypub/src/routes.tsxapps/activitypub/src/views/preferences/components/mastodon-migration.tsxapps/activitypub/src/views/preferences/components/settings.tsxapps/activitypub/test/acceptance/preferences.test.ts
✅ Files skipped from review due to trivial changes (1)
- apps/activitypub/package.json
🚧 Files skipped from review as they are similar to previous changes (5)
- apps/activitypub/src/api/activitypub.test.ts
- apps/activitypub/src/api/activitypub.ts
- apps/activitypub/test/acceptance/preferences.test.ts
- apps/activitypub/src/hooks/use-activity-pub-queries.ts
- apps/activitypub/src/views/preferences/components/settings.tsx
JohnONolan
force-pushed
the
codex/mastodon-migration-ui
branch
from
c5ad5c1 to
0461364
Compare
JohnONolan
changed the title
JohnONolan
force-pushed
the
codex/mastodon-migration-ui
branch
from
0461364 to
2705e8b
Compare
Adds the ActivityPub preferences page for creating and removing account aliases used by Mastodon-to-Ghost follower migration.\n\nIncludes the client API/query hooks, settings route, empty/error/loading behavior, and acceptance coverage for creating aliases, existing alias ordering, and load failures.
JohnONolan
force-pushed
the
codex/mastodon-migration-ui
branch
from
2705e8b to
fd4bf56
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/activitypub/src/views/preferences/components/account-migration.tsx`:
- Around line 182-189: The button currently replaces its content with just
<LoadingIndicator> when removingAlias === alias.apId, which removes the readable
name for assistive tech; instead keep an accessible label by preserving the
"Unlink" text (or adding an explicit aria-label) when rendering the loading
state and mark the spinner aria-hidden so screen readers don't announce it.
Update the Button in account-migration.tsx (the button using removingAlias,
alias.apId, handleRemoveAlias, <LoadingIndicator> and <LucideIcon.Trash2>) to
render the spinner alongside a visually-hidden or visible "Unlink" text (or set
aria-label="Unlink" on the Button) while disabled, ensuring the spinner has
aria-hidden="true".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c92f9181-b4fe-46c9-9300-6a111873614b
📒 Files selected for processing (8)
apps/activitypub/package.jsonapps/activitypub/src/api/activitypub.test.tsapps/activitypub/src/api/activitypub.tsapps/activitypub/src/hooks/use-activity-pub-queries.tsapps/activitypub/src/routes.tsxapps/activitypub/src/views/preferences/components/account-migration.tsxapps/activitypub/src/views/preferences/components/settings.tsxapps/activitypub/test/acceptance/preferences.test.ts
✅ Files skipped from review due to trivial changes (1)
- apps/activitypub/package.json
🚧 Files skipped from review as they are similar to previous changes (6)
- apps/activitypub/src/routes.tsx
- apps/activitypub/src/api/activitypub.ts
- apps/activitypub/src/api/activitypub.test.ts
- apps/activitypub/src/views/preferences/components/settings.tsx
- apps/activitypub/test/acceptance/preferences.test.ts
- apps/activitypub/src/hooks/use-activity-pub-queries.ts
Comment on lines
+182
to
+189
| <Button | ||
| className='shrink-0 px-0 font-medium text-gray-700 hover:text-red dark:text-gray-600 dark:hover:text-red' | ||
| disabled={removingAlias === alias.apId} | ||
| variant='link' | ||
| onClick={() => handleRemoveAlias(alias.apId)} | ||
| > | ||
| {removingAlias === alias.apId ? <LoadingIndicator size='sm' /> : <><LucideIcon.Trash2 size={15} /> Unlink</>} | ||
| </Button> |
Contributor
There was a problem hiding this comment.
Keep an accessible label while unlink is loading.
At Line 188, replacing the entire button content with a spinner can leave the control without a readable name for assistive tech. Keep/restore an accessible text label in the loading state.
Suggested fix
- {removingAlias === alias.apId ? <LoadingIndicator size='sm' /> : <><LucideIcon.Trash2 size={15} /> Unlink</>}
+ {removingAlias === alias.apId ? (
+ <>
+ <LoadingIndicator size='sm' />
+ <span className='sr-only'>Unlinking alias...</span>
+ </>
+ ) : (
+ <>
+ <LucideIcon.Trash2 size={15} /> Unlink
+ </>
+ )}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <Button | |
| className='shrink-0 px-0 font-medium text-gray-700 hover:text-red dark:text-gray-600 dark:hover:text-red' | |
| disabled={removingAlias === alias.apId} | |
| variant='link' | |
| onClick={() => handleRemoveAlias(alias.apId)} | |
| > | |
| {removingAlias === alias.apId ? <LoadingIndicator size='sm' /> : <><LucideIcon.Trash2 size={15} /> Unlink</>} | |
| </Button> | |
| <Button | |
| className='shrink-0 px-0 font-medium text-gray-700 hover:text-red dark:text-gray-600 dark:hover:text-red' | |
| disabled={removingAlias === alias.apId} | |
| variant='link' | |
| onClick={() => handleRemoveAlias(alias.apId)} | |
| > | |
| {removingAlias === alias.apId ? ( | |
| <> | |
| <LoadingIndicator size='sm' /> | |
| <span className='sr-only'>Unlinking alias...</span> | |
| </> | |
| ) : ( | |
| <> | |
| <LucideIcon.Trash2 size={15} /> Unlink | |
| </> | |
| )} | |
| </Button> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/activitypub/src/views/preferences/components/account-migration.tsx`
around lines 182 - 189, The button currently replaces its content with just
<LoadingIndicator> when removingAlias === alias.apId, which removes the readable
name for assistive tech; instead keep an accessible label by preserving the
"Unlink" text (or adding an explicit aria-label) when rendering the loading
state and mark the spinner aria-hidden so screen readers don't announce it.
Update the Button in account-migration.tsx (the button using removingAlias,
alias.apId, handleRemoveAlias, <LoadingIndicator> and <LucideIcon.Trash2>) to
render the spinner alongside a visually-hidden or visible "Unlink" text (or set
aria-label="Unlink" on the Button) while disabled, ensuring the spinner has
aria-hidden="true".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for inbound social web account migration, so that (eg) you can migrate a mastodon profile to Ghost, and the followers will move over:
Depends on: TryGhost/ActivityPub#1804
https://docs.joinmastodon.org/user/moving/#move
Summary
Why
Ghost Admin needs a UI for configuring the old Mastodon/social web account before the user starts the move from their old account. The UI calls the new ActivityPub alias API and keeps the workflow inside ActivityPub preferences.