Skip to content

Changed Shade field spacing#27994

Merged
peterzimon merged 1 commit into
mainfrom
DES-1384/fix-shade-field-spacing
May 20, 2026
Merged

Changed Shade field spacing#27994
peterzimon merged 1 commit into
mainfrom
DES-1384/fix-shade-field-spacing

Conversation

@peterzimon
Copy link
Copy Markdown
Contributor

@peterzimon peterzimon commented May 20, 2026

ref https://linear.app/ghost/issue/DES-1384/reduce-gap-between-fieldlabel-and-fielddescription

  • tightened the default vertical spacing in Shade field and legend layout
  • removed the local negative margin from the ActivityPub account migration description
  • included the ActivityPub package patch version bump generated by the commit hook

Why

Field descriptions were carrying more vertical space than needed, which led consumers to compensate with local spacing overrides. Moving the tighter spacing into Shade keeps the layout consistent at the shared component level.

ref https://linear.app/tryghost/issue/DES-1384/

Field descriptions had more vertical spacing than desired, and one consumer compensated with a local negative margin. This updates the shared Shade defaults so field layouts are consistently tighter without component-specific spacing overrides.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4fc02b79-d3c4-4291-9ead-0ebe892fa595

📥 Commits

Reviewing files that changed from the base of the PR and between 103de7e and edd8f04.

📒 Files selected for processing (3)
  • apps/activitypub/package.json
  • apps/activitypub/src/views/preferences/components/account-migration.tsx
  • apps/shade/src/components/ui/field.tsx

Walkthrough

This pull request adjusts spacing and styling across field components. The base field component in apps/shade reduces legend bottom margin from mb-3 to mb-2 and field container gap from gap-3 to gap-2. The account migration form removes a -mt-1 margin class from the old account handle field description. The ActivityPub package version is bumped from 3.1.25 to 3.1.26. All changes are styling refinements with no behavioral logic changes.

Suggested reviewers

  • weylandswart
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Changed Shade field spacing' directly and clearly summarizes the main change: updating spacing in the Shade field component.
Description check ✅ Passed The description provides clear context about the spacing changes in Shade fields and explains the rationale for the modifications across multiple files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch DES-1384/fix-shade-field-spacing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@peterzimon peterzimon changed the title [codex] Changed Shade field spacing Changed Shade field spacing May 20, 2026
@peterzimon peterzimon marked this pull request as ready for review May 20, 2026 15:12
@peterzimon peterzimon enabled auto-merge (squash) May 20, 2026 15:12
@peterzimon peterzimon disabled auto-merge May 20, 2026 15:16
@peterzimon peterzimon enabled auto-merge (squash) May 20, 2026 15:16
@peterzimon peterzimon merged commit 03bb7da into main May 20, 2026
42 checks passed
@peterzimon peterzimon deleted the DES-1384/fix-shade-field-spacing branch May 20, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant