Skipped flaky cache-invalidation unit test under vitest#28049
Conversation
- the test cold-requires every endpoint controller in a single test body; under vitest's per-file module isolation that intermittently exceeds the 2000ms testTimeout on loaded CI runners, which is currently breaking main - skipping unblocks CI now; the test is restored when ghost/core's unit suite moves to a shared module registry (isolate: false), where the controller requires are warm and fast
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR temporarily disables a cache-invalidation test case by converting it to a skipped test with explanatory comments. The change adds a note that the skip is due to intermittent CI timeouts caused by per-file module isolation, and indicates the test should be restored once the Ghost unit suite uses a shared module registry. An eslint directive is added to allow the skipped test rule. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The
cache-invalidationunit test cold-require()s every endpoint controller inside a single test body. Under vitest's per-file module isolation each test file gets a fresh module registry, so this test pays the full cold-import cost of a large slice of Ghost on its own — and that intermittently exceeds the 2000mstestTimeouton loaded CI runners, currently breakingmain.This skips the test to unblock CI. It's a deliberate, temporary measure: the test is restored as part of moving ghost/core's unit suite to a shared module registry (
isolate: false), where the controllerrequire()s are warm and the test runs well under the timeout.