Added translation for gift subscription product in Stripe#28065
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
WalkthroughThe Stripe gift checkout product name and cadence label generation were changed to use the i18n translation helper ( Possibly related PRs
Suggested labelsaffects:i18n Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ghost/core/core/server/services/stripe/stripe-api.js`:
- Around line 706-708: The product title is being built by concatenating
translated fragments and fixed punctuation which prevents locales from
controlling word order; update the code that currently uses name: `${t('Gift
subscription')} — ${tierName} (${cadenceLabel})` to use a single translation key
(via t(...)) that accepts interpolations for tierName and cadenceLabel, e.g.
t('Gift subscription: {tier} ({cadence})', {tier: tierName, cadence:
cadenceLabel}), and ensure cadenceLabel is still computed (cadenceLabel
variable) before calling t so the full title string comes from one localized
key; replace occurrences of the concatenation with this single-key interpolation
approach (refer to cadenceLabel, tierName and the t(...) call in stripe-api.js).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d1c8639f-331a-4226-a427-0e62e7b6004d
📒 Files selected for processing (65)
ghost/core/core/server/services/stripe/stripe-api.jsghost/core/test/unit/server/services/stripe/stripe-api.test.jsghost/i18n/locales/af/ghost.jsonghost/i18n/locales/ar/ghost.jsonghost/i18n/locales/bg/ghost.jsonghost/i18n/locales/bn/ghost.jsonghost/i18n/locales/bs/ghost.jsonghost/i18n/locales/ca/ghost.jsonghost/i18n/locales/context.jsonghost/i18n/locales/cs/ghost.jsonghost/i18n/locales/da/ghost.jsonghost/i18n/locales/de-CH/ghost.jsonghost/i18n/locales/de/ghost.jsonghost/i18n/locales/el/ghost.jsonghost/i18n/locales/en/ghost.jsonghost/i18n/locales/eo/ghost.jsonghost/i18n/locales/es/ghost.jsonghost/i18n/locales/et/ghost.jsonghost/i18n/locales/eu/ghost.jsonghost/i18n/locales/fa/ghost.jsonghost/i18n/locales/fi/ghost.jsonghost/i18n/locales/fr/ghost.jsonghost/i18n/locales/gd/ghost.jsonghost/i18n/locales/he/ghost.jsonghost/i18n/locales/hi/ghost.jsonghost/i18n/locales/hr/ghost.jsonghost/i18n/locales/hu/ghost.jsonghost/i18n/locales/id/ghost.jsonghost/i18n/locales/is/ghost.jsonghost/i18n/locales/it/ghost.jsonghost/i18n/locales/ja/ghost.jsonghost/i18n/locales/ko/ghost.jsonghost/i18n/locales/kz/ghost.jsonghost/i18n/locales/lt/ghost.jsonghost/i18n/locales/lv/ghost.jsonghost/i18n/locales/mk/ghost.jsonghost/i18n/locales/mn/ghost.jsonghost/i18n/locales/ms/ghost.jsonghost/i18n/locales/nb/ghost.jsonghost/i18n/locales/ne/ghost.jsonghost/i18n/locales/nl/ghost.jsonghost/i18n/locales/nn/ghost.jsonghost/i18n/locales/pa/ghost.jsonghost/i18n/locales/pl/ghost.jsonghost/i18n/locales/pt-BR/ghost.jsonghost/i18n/locales/pt/ghost.jsonghost/i18n/locales/ro/ghost.jsonghost/i18n/locales/ru/ghost.jsonghost/i18n/locales/si/ghost.jsonghost/i18n/locales/sk/ghost.jsonghost/i18n/locales/sl/ghost.jsonghost/i18n/locales/sq/ghost.jsonghost/i18n/locales/sr-Cyrl/ghost.jsonghost/i18n/locales/sr/ghost.jsonghost/i18n/locales/sv/ghost.jsonghost/i18n/locales/sw/ghost.jsonghost/i18n/locales/ta/ghost.jsonghost/i18n/locales/th/ghost.jsonghost/i18n/locales/tr/ghost.jsonghost/i18n/locales/uk/ghost.jsonghost/i18n/locales/ur/ghost.jsonghost/i18n/locales/uz/ghost.jsonghost/i18n/locales/vi/ghost.jsonghost/i18n/locales/zh-Hant/ghost.jsonghost/i18n/locales/zh/ghost.json
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: mike182uk <991592+mike182uk@users.noreply.github.com>
Merged |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 1m 55s | View ↗ |
nx run @tryghost/admin-x-settings:test:acceptance |
✅ Succeeded | 9m 5s | View ↗ |
nx run ghost:test:ci:e2e |
✅ Succeeded | 7m 30s | View ↗ |
nx build @tryghost/portal |
✅ Succeeded | 1s | View ↗ |
nx build @tryghost/signup-form |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/comments-ui |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/activitypub |
✅ Succeeded | 2s | View ↗ |
nx build @tryghost/announcement-bar |
✅ Succeeded | <1s | View ↗ |
Additional runs (10) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-05-26 16:08:05 UTC
closes #28063
closes https://linear.app/ghost/issue/ONC-1759
Abonnement offert — Pro (1 mois)instead of:
Gift Subscription - Pro (1 month)-by em dash—