Fixed browser-sensitive admin CI tests#28070
Conversation
ref #28047 The Blacksmith migration exposed a couple of admin tests that depended on browser-version-specific behavior. Use the legacy keyCode path expected by keymaster, avoid stubbing cross-origin iframe contentWindow methods directly, and make the Docker image tag selection pipefail-safe for multiline inputs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR contains three independent, small-scale updates across infrastructure and test code. The Docker action refactoring simplifies tag extraction using shell parameter expansion instead of printf/head in two locations. The search test updates keyboard event dispatch to use numeric key codes. The billing iframe integration tests are refactored to stub an internal component method ( Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28070 +/- ##
=======================================
Coverage 73.81% 73.82%
=======================================
Files 1528 1528
Lines 129417 129417
Branches 15506 15509 +3
=======================================
+ Hits 95527 95537 +10
- Misses 32910 32924 +14
+ Partials 980 956 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Context
This came out of investigating failures on #28047 while testing Blacksmith runners. The changes are not Blacksmith-specific; they harden tests and CI shell behavior that can vary by browser/runtime.
Testing