Changed E2E report merging to run only on failure#28077
Conversation
The merge job only has useful work when failed E2E shards upload blob reports. Skipping it on green runs avoids an extra checkout, install, artifact lookup and empty merge step.
WalkthroughThe pull request modifies the CI workflow in 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28077 +/- ##
==========================================
- Coverage 73.82% 73.81% -0.01%
==========================================
Files 1528 1528
Lines 129417 129417
Branches 15509 15506 -3
==========================================
- Hits 95538 95527 -11
- Misses 32899 32934 +35
+ Partials 980 956 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Expected savings
Based on recent successful CI runs,
Merge Reportscurrently still runs on green E2E even though no blob reports exist to merge:Expected green-run wall-clock saving: about 50-60 seconds, mostly checkout, Node setup, and
pnpm installbefore discovering there are no reports.Conditions
job_e2e_testssucceeds.Testing