Skip to content

Changed E2E report merging to run only on failure#28077

Merged
9larsons merged 1 commit into
mainfrom
codex/skip-green-e2e-report-merge
May 23, 2026
Merged

Changed E2E report merging to run only on failure#28077
9larsons merged 1 commit into
mainfrom
codex/skip-green-e2e-report-merge

Conversation

@9larsons
Copy link
Copy Markdown
Contributor

@9larsons 9larsons commented May 23, 2026

Summary

  • skips the E2E report merge job when the E2E matrix succeeds
  • keeps report generation for failed E2E runs, where blob reports are uploaded and useful for debugging

Expected savings

Based on recent successful CI runs, Merge Reports currently still runs on green E2E even though no blob reports exist to merge:

Run Merge Reports duration
26312347409 48s
26312115502 60s
26312016790 52s
26311870687 52s

Expected green-run wall-clock saving: about 50-60 seconds, mostly checkout, Node setup, and pnpm install before discovering there are no reports.

Conditions

  • Saves time only when job_e2e_tests succeeds.
  • No behavior change for failed E2E runs; failed shards still upload blob reports and this job still merges/uploads the HTML report.
  • No behavior change when the E2E lane is skipped; the merge job remains skipped.

Testing

  • not run; workflow-only condition change

The merge job only has useful work when failed E2E shards upload blob reports. Skipping it on green runs avoids an extra checkout, install, artifact lookup and empty merge step.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 23, 2026

Review Change Stack

Walkthrough

The pull request modifies the CI workflow in .github/workflows/ci.yml to add a conditional check to the job_merge_e2e_reports job. The job's execution condition is refined from running unconditionally under always() to only executing when always() is true and the E2E tests job result is 'failure'. This ensures that merge-report operations only occur when E2E tests actually fail, preventing unnecessary execution on successful test runs.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: modifying the E2E report merging job to run only when E2E tests fail, which aligns with the actual change in the workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly relates to the changeset: it explains the conditional change to skip E2E report merging on successful runs, provides quantified time savings, and outlines expected behavior changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/skip-green-e2e-report-merge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.81%. Comparing base (b9a0f75) to head (0433200).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #28077      +/-   ##
==========================================
- Coverage   73.82%   73.81%   -0.01%     
==========================================
  Files        1528     1528              
  Lines      129417   129417              
  Branches    15509    15506       -3     
==========================================
- Hits        95538    95527      -11     
- Misses      32899    32934      +35     
+ Partials      980      956      -24     
Flag Coverage Δ
admin-tests 54.03% <ø> (-0.01%) ⬇️
e2e-tests 73.81% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons 9larsons merged commit c5d1193 into main May 23, 2026
48 checks passed
@9larsons 9larsons deleted the codex/skip-green-e2e-report-merge branch May 23, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant