Skip to content

Changed Docker image artifact upload to fork-only#28078

Merged
9larsons merged 1 commit into
mainfrom
codex/skip-docker-artifact-upload
May 23, 2026
Merged

Changed Docker image artifact upload to fork-only#28078
9larsons merged 1 commit into
mainfrom
codex/skip-docker-artifact-upload

Conversation

@9larsons
Copy link
Copy Markdown
Contributor

@9larsons 9larsons commented May 23, 2026

Summary

  • skips saving/uploading the production Docker image artifact when CI can push/pull from GHCR
  • keeps the artifact transfer path for external fork and cross-repo PR runs where GHCR push is unavailable

Expected savings

Based on recent successful same-org CI runs, the production image tarball is saved and uploaded even though downstream jobs pull the image from GHCR:

Run Save full image as artifact Upload image artifact Total
26312347409 26s 9s 35s
26312115502 45s 9s 54s
26312016790 41s 9s 50s
26311870687 37s 10s 47s

Expected same-org build-lane saving: about 35-55 seconds in Build & Publish Artifacts. This can also unblock Build E2E Docker Image sooner because that job depends on job_build_artifacts.

Conditions

  • Saves time when steps.strategy.outputs.use-artifact == 'false', which is the normal same-org path where images are pushed to GHCR.
  • Keeps existing behavior when use-artifact == 'true', which covers external forks and cross-repo PRs that cannot push the image to GHCR.
  • Release/tag pushes are unaffected because the strategy forces use-artifact=false and publishes images to GHCR.

Testing

  • not run; workflow-only condition change

Same-org CI runs publish Docker images to GHCR, so downstream jobs can pull from the registry and do not need a saved tarball artifact. Keeping the artifact path only for fork/cross-repo PRs avoids unnecessary docker save and upload work on the common path.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 23, 2026

Review Change Stack

Walkthrough

The PR adds conditional if gates to two sequential steps in the job_build_artifacts job within the CI workflow. Both the "Save full image as artifact" step and the "Upload image artifact" step are now conditionally executed only when steps.strategy.outputs.use-artifact == 'true'. This allows the workflow to skip Docker image artifact creation and upload based on the strategy output variable, reducing unnecessary artifact storage when not required.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: conditionally running Docker image artifact upload only for forks. It directly reflects the changeset's primary objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the conditional logic added to skip artifact uploads in same-org runs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/skip-docker-artifact-upload

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.81%. Comparing base (88d5d08) to head (105985d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #28078   +/-   ##
=======================================
  Coverage   73.80%   73.81%           
=======================================
  Files        1528     1528           
  Lines      129417   129417           
  Branches    15504    15506    +2     
=======================================
+ Hits        95521    95527    +6     
- Misses      32917    32934   +17     
+ Partials      979      956   -23     
Flag Coverage Δ
admin-tests 54.03% <ø> (ø)
e2e-tests 73.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons 9larsons merged commit fc250d2 into main May 23, 2026
48 checks passed
@9larsons 9larsons deleted the codex/skip-docker-artifact-upload branch May 23, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant