Changed main E2E tests to run across ten shards#28079
Conversation
The current eight-shard main E2E split has a consistent long shard around eleven minutes. Trying ten main shards is a small, reversible experiment to see whether Playwright's native sharding can lower the slowest shard before we invest in manual file rebalancing.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe CI workflow in Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28079 +/- ##
=======================================
Coverage 73.80% 73.81%
=======================================
Files 1528 1528
Lines 129417 129417
Branches 15504 15506 +2
=======================================
+ Hits 95521 95528 +7
+ Misses 32917 32910 -7
Partials 979 979
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
TEST_WORKERS_COUNT=1unchangedExpected impact
Historic successful CI runs show the current main E2E split is consistently bottlenecked by one or two slow shards:
Average main-shard setup is about 2m, so adding two shards adds roughly 4m of total runner setup, but wall-clock can improve if the slowest Playwright shard drops by more than the fixed setup cost on that lane.
Expected wall-clock saving: likely 1-2 minutes if Playwright's native file/test grouping spreads the current long shard better; best case is larger, but unlikely because the suite is not
fullyParalleland large files remain chunky.Success criteria
Compare this PR's E2E matrix with recent baseline runs and check:
If this only moves the bottleneck, the next better step is splitting or manually binning the large files instead of adding more shards.
Testing