Started confirming automation re-publish by EvanHahn · Pull Request #28113 · TryGhost/Ghost

EvanHahn · 2026-05-25T17:15:32Z

closes https://linear.app/ghost/issue/NY-1299

Screencast.mp4

If an automation is active and you go to update it, we now show a confirmation dialog.

This change has no effect for inactive automations.

closes https://linear.app/ghost/issue/NY-1299 If an automation is active and you go to update it, we now show a confirmation dialog. This change has no effect for inactive automations.

coderabbitai · 2026-05-25T17:15:49Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ce53627b-a6ef-4028-bdd2-0228ae145995

📥 Commits

Reviewing files that changed from the base of the PR and between 87b6c6e and b4d876c.

📒 Files selected for processing (3)

apps/posts/src/views/Automations/editor.tsx
apps/posts/src/views/Automations/types.ts
apps/posts/test/unit/views/automations/automation-editor.test.tsx

Walkthrough

This PR extends the automation editor's state machine to support republishing active automations through a user confirmation flow. A new AutomationEditState type is introduced with 're-publishing', 'confirming re-publish', and 'failed to re-publish' states. The save() function is refactored to compute state transitions from old-to-new status values, enabling explicit republish paths. When publishing an active draft, the UI now routes to a confirmation modal ("Update automation?") instead of immediately saving; inactive drafts proceed directly to save. The edit state switch is extended with handlers for the new republish states that control dialog visibility, button state, and retry styling. Test coverage is updated to verify the confirmation modal appears, prevents immediate mutation, and supports retrying after failures.

Possibly related PRs

TryGhost/Ghost#27852: Updates AutomationHeader publish button state and label when automation is active, directly related to the header wiring changes in this PR.
TryGhost/Ghost#28055: Refactors automation editor save() UI state-machine and AutomationHeader prop wiring for the same useEditAutomation mutation flow, including inactive save/retry patterns.
TryGhost/Ghost#27857: Modifies automation editor publish/turn-on/off state machine and useEditAutomation wiring, which this PR extends with republish confirmation and failure states.

Suggested labels

ok to merge for me

Suggested reviewers

troyciesco
cmraible

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a confirmation dialog when re-publishing (updating) an active automation, which is the core feature introduced in this PR.
Description check	✅ Passed	The description is directly related to the changeset, explaining that a confirmation dialog now appears when updating an active automation, with no effect for inactive ones.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch evanhahn-ny-1299-before-publishing-an-active-automation-confirm-with-user

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

EvanHahn · 2026-05-25T17:16:17Z

@@ -173,27 +233,49 @@ const AutomationEditor: React.FC = () => {
    const onConfirmUnpublishOpenChange = (open: boolean): void => {


Not strictly in scope, but I simplified this alert open change callback because I was adding a new similar one.

EvanHahn · 2026-05-25T17:16:49Z

+                    <AlertDialogHeader>
+                        <AlertDialogTitle>Update automation?</AlertDialogTitle>
+                        <AlertDialogDescription>
+                            This will update the automation for new runs of the automation, as well as any actively-running ones.


I'm not 100% sure on this copy, but we can tweak it.

EvanHahn · 2026-05-25T17:18:29Z

troyciesco · 2026-05-25T20:02:58Z

+
+        const oldStatus = draft.status;
+        const newStatus = statusToSave ?? oldStatus;
+        const statusTransition: `${AutomationStatus} -> ${AutomationStatus}` = `${oldStatus} -> ${newStatus}`;


ooooo trickyyyy

Couldn't tell if this was too clever, but it succinctly described what I wanted...

troyciesco · 2026-05-25T20:18:46Z

+            case 'confirming re-publish':
+            case 'failed to re-publish':


not something for this PR, but i'm wondering if we should clean up these states into something other than strings as they continue to grow.

For example, there's sort of a relationship here between these two states, or any two states that're like confirming <whatever> and failed <whatever>.

In all of these functions we don't really have to worry about typos or anything since TypeScript is doing the heavy-lifting, but it kinda feels like the AutomationEditState bucket might be too general now. I'm also finding this harder to read as it grows.

Maybe syntax like state.republish.confirming or something like that? Not urgent, might be a fun one for 2-3 of us to pair on when we're in a QA window just as a chance to talk shop.

Good idea. Made a cleanup ticket.

…28121) ref #28113 The `updates a wait step as the wait editor value changes` test in `apps/posts` has been failing on `main` since #28113 merged. This PR adds the two lines needed to click through the new "Update automation?" confirmation dialog.

Started confirming automation re-publish

b4d876c

closes https://linear.app/ghost/issue/NY-1299 If an automation is active and you go to update it, we now show a confirmation dialog. This change has no effect for inactive automations.

This comment was marked as low quality.

Sign in to view

EvanHahn commented May 25, 2026

View reviewed changes

EvanHahn requested a review from troyciesco May 25, 2026 17:19

EvanHahn added the ok to merge for me You can merge this on my behalf if you want. label May 25, 2026

EvanHahn mentioned this pull request May 25, 2026

Started confirming automation edit abandonment #28114

Merged

troyciesco approved these changes May 25, 2026

View reviewed changes

troyciesco merged commit e830217 into main May 25, 2026
47 checks passed

troyciesco deleted the evanhahn-ny-1299-before-publishing-an-active-automation-confirm-with-user branch May 25, 2026 20:32

9larsons mentioned this pull request May 25, 2026

Fixed broken wait-step test on main from publish-confirm merge skew #28121

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Started confirming automation re-publish#28113

Started confirming automation re-publish#28113
troyciesco merged 1 commit into
mainfrom
evanhahn-ny-1299-before-publishing-an-active-automation-confirm-with-user

EvanHahn commented May 25, 2026

Uh oh!

coderabbitai Bot commented May 25, 2026 •

edited

Loading

Uh oh!

This comment was marked as low quality.

This comment was marked as low quality.

EvanHahn May 25, 2026

Uh oh!

EvanHahn May 25, 2026

Uh oh!

EvanHahn May 25, 2026

Uh oh!

troyciesco May 25, 2026

Uh oh!

EvanHahn May 25, 2026

Uh oh!

troyciesco May 25, 2026

Uh oh!

EvanHahn May 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -173,27 +233,49 @@ const AutomationEditor: React.FC = () => {
		const onConfirmUnpublishOpenChange = (open: boolean): void => {

Uh oh!

Conversation

EvanHahn commented May 25, 2026

Uh oh!

coderabbitai Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

This comment was marked as low quality.

This comment was marked as low quality.

EvanHahn May 25, 2026

Choose a reason for hiding this comment

Uh oh!

EvanHahn May 25, 2026

Choose a reason for hiding this comment

Uh oh!

EvanHahn May 25, 2026

Choose a reason for hiding this comment

Uh oh!

troyciesco May 25, 2026

Choose a reason for hiding this comment

Uh oh!

EvanHahn May 25, 2026

Choose a reason for hiding this comment

Uh oh!

troyciesco May 25, 2026

Choose a reason for hiding this comment

Uh oh!

EvanHahn May 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented May 25, 2026 •

edited

Loading