Removed test:unit scripts from projects with no Vitest unit tests#28116
Conversation
- apps/signup-form's test:unit ran 'pnpm build' (not tests). Its only file in test/unit/ was an empty hello.test.js that never executed. Removed both. - apps/sodo-search's test:unit ran vitest run --coverage against zero unit test files. Its Playwright tests live under test:acceptance and are unaffected. Removed test:unit and the test:ci script it chained through. - ghost-admin's test:unit was 'true' (no-op). ghost-admin's actual tests run via 'ember exam' under its own test target, invoked by the dedicated ghost-admin CI job. nx run-many -t test:unit now skips these three projects (16 → 13). Adding tests later means adding the script back — one line — and nx picks them up automatically. Bumped signup-form and sodo-search versions for the app-version-bump check; ghost-admin is not in MONITORED_APPS so no bump needed.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR increments patch versions and removes deprecated npm test scripts across three app manifests, and updates the CI workflow to detect unit-test-global changes and compute a dedicated unit_test_projects_str. Package changes: apps/signup-form → 0.3.27 (removed test:unit), apps/sodo-search → 1.8.21 (removed test:ci and test:unit), ghost/admin (removed test:unit). CI changes: add paths-filter entries for unit-test globals, compute and expose job_setup.outputs.unit_test_projects_str, and gate/run the unit-test job using that value. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t test:unit -p @tryghost/signup-fo... |
✅ Succeeded | <1s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-05-25 19:49:45 UTC
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 2m | View ↗ |
nx run @tryghost/admin-x-settings:test:acceptance |
✅ Succeeded | 9m 18s | View ↗ |
nx run ghost:test:ci:e2e |
✅ Succeeded | 7m 39s | View ↗ |
nx run ghost:test:ci:legacy |
✅ Succeeded | 3m 3s | View ↗ |
nx build @tryghost/comments-ui |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/portal |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/announcement-bar |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/signup-form |
✅ Succeeded | <1s | View ↗ |
Additional runs (12) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-05-25 20:18:11 UTC
ref #28115 Shared Vitest config changes can affect more tests than Nx marks as changed, so CI now widens unit-test project selection for root config changes while keeping Ghost core config changes scoped to Ghost core.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28116 +/- ##
=======================================
Coverage 73.83% 73.83%
=======================================
Files 1528 1528
Lines 129467 129454 -13
Branches 15518 15518
=======================================
- Hits 95587 95580 -7
+ Misses 32919 32889 -30
- Partials 961 985 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Three workspaces had a
test:unitscript that didn't actually run unit tests, which inflated theci_test_unitmatrix from 13 real test runs to 16 and made the intent of those projects' test wiring hard to read.apps/signup-form:test:unitwaspnpm build— running the build, not tests. There was a singletest/unit/hello.test.js(0 bytes) that never executed under that script. Removed the script and the placeholder file.apps/sodo-search:test:unitchained throughtest:citovitest run --coverageagainst zero unit test files. The project's actual tests are Playwright (test/e2e/*.test.ts) and run in the separateunit_tests_playwrightmatrix — unaffected by this change. Removed bothtest:unitandtest:ci(the latter has no other callers).ghost-admin:test:unitwastrue(no-op). ghost-admin's tests run viaember examunder its owntesttarget, invoked by the dedicatedghost-admin:testCI job. Removed.After this change,
pnpm nx run-many -t test:unitruns 13 projects instead of 16. Nx skips projects without the target — no extra wiring or exemption list to maintain. If/when one of these workspaces adds real Vitest tests, adding thetest:unitscript back is a one-line change.Versions bumped on
signup-formandsodo-searchper the app-version-bump check.ghost-adminisprivate: trueand not in.github/scripts/check-app-version-bump.js'sMONITORED_APPS, so no bump needed.