Fix silent content import failures when author validation fails#28156
Open
jameslcowan wants to merge 10000 commits into
Open
Fix silent content import failures when author validation fails#28156jameslcowan wants to merge 10000 commits into
jameslcowan wants to merge 10000 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26268
When a JSON import hits validation errors (bad email, bio too long, etc.), the data importer was throwing a raw array instead of a proper error. Node logs that as
rejected with a non-error: [object Array], and the failure email just says to contact support — no hint which author or field failed.This wraps those errors in a DataImportError with readable messages (including the user email when we have it from import context) and shows those details in the import failure email.
Test plan
pnpm testin ghost/core (or at least import-errors.test.js)