Skip to content

Updated @tryghost/domain-events to latest version#28241

Merged
EvanHahn merged 1 commit into
mainfrom
update-domain-events
May 28, 2026
Merged

Updated @tryghost/domain-events to latest version#28241
EvanHahn merged 1 commit into
mainfrom
update-domain-events

Conversation

@EvanHahn
Copy link
Copy Markdown
Contributor

no ref

All I did was run pnpm add @tryghost/domain-events@latest --save-exact from ghost/core/.

This change should have no user impact. Best I understand, nothing significant changed (which I verified by running git diff @tryghost/domain-events@1.0.8...@tryghost/domain-events@3.2.3 packages/domain-events from the Framework repo).

no ref

All I did was run `pnpm add @tryghost/domain-events@latest --save-exact`
from `ghost/core/`.

This change should have no user impact. Best I understand, nothing
significant changed (which I verified by running `git diff
@tryghost/domain-events@1.0.8...@tryghost/domain-events@3.2.3
packages/domain-events` from the Framework repo).
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7e70ef1b-1182-45e0-be7d-d2f999372e6a

📥 Commits

Reviewing files that changed from the base of the PR and between 2c6439e and 8433285.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • ghost/core/package.json
  • pnpm-workspace.yaml

Walkthrough

This PR migrates the @tryghost/domain-events dependency from a pinned version in ghost/core/package.json to pnpm workspace catalog management. The change adds the dependency with version 3.2.3 to the catalog section in pnpm-workspace.yaml and updates the package.json to reference it via the catalog: specifier instead of the previous pinned 1.0.8 version.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the @tryghost/domain-events dependency to the latest version, which is the primary purpose of this pull request.
Description check ✅ Passed The description is directly related to the changeset, explaining the update command used, the version change from 1.0.8 to 3.2.3, and the verification performed to ensure no significant changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-domain-events

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.63%. Comparing base (2c6439e) to head (8433285).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #28241   +/-   ##
=======================================
  Coverage   73.63%   73.63%           
=======================================
  Files        1536     1536           
  Lines      130748   130748           
  Branches    15641    15642    +1     
=======================================
  Hits        96272    96272           
  Misses      33511    33511           
  Partials      965      965           
Flag Coverage Δ
admin-tests 54.20% <ø> (ø)
e2e-tests 73.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EvanHahn EvanHahn merged commit 1c973ef into main May 28, 2026
54 checks passed
@EvanHahn EvanHahn deleted the update-domain-events branch May 28, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant