Added admin-toolbar to CI publish pipeline and release tooling#28244
Conversation
The admin-toolbar package was missing from the npm publish matrix, version bump checks, release scripts, E2E artifact archive, and devcontainer config — so jsDelivr could never serve it in production. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughThis PR integrates the Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/admin-toolbar/package.json`:
- Line 26: The "ship" npm script currently runs the release script with "node
..." and must be prefixed with pnpm to follow repo policy; update the "ship"
script value (the "ship" key in package.json) to invoke the release script via
pnpm (i.e., replace the current command "node
../../.github/scripts/release-apps.js" with the same invocation prefixed by
"pnpm") so the workspace uses pnpm for running the script.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 514801ee-812a-48d9-bc64-373c1ef054bd
📒 Files selected for processing (5)
.devcontainer/compose.devcontainer.yaml.github/scripts/check-app-version-bump.js.github/scripts/release-apps.js.github/workflows/ci.ymlapps/admin-toolbar/package.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28244 +/- ##
=======================================
Coverage 73.62% 73.62%
=======================================
Files 1537 1537
Lines 130819 130819
Branches 15655 15654 -1
=======================================
+ Hits 96320 96322 +2
- Misses 33508 33531 +23
+ Partials 991 966 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
@tryghost/admin-toolbarpackage was never published to npm, so the jsDelivr CDN URL returns 404 in production — the toolbar only worked in dev mode where Docker overrides the URL to a local Vite server.build_packagesandpublish_packagesmatrices, the E2E artifact archive, version bump checks, release scripts, and devcontainer config — matching the setup of every other public app (portal, comments-ui, sodo-search, signup-form, announcement-bar).Changes
.github/workflows/ci.yml— added tobuild_packagesmatrix,publish_packagesmatrix, and E2E tar archive.github/scripts/release-apps.js— added toCONFIG_KEYSsopnpm shipworks.github/scripts/check-app-version-bump.js— added toMONITORED_APPSso version bumps are enforced on PRsapps/admin-toolbar/package.json— addedship/preship/prepublishOnlyscripts, removedsrc/from published files.devcontainer/compose.devcontainer.yaml— addedADMIN_TOOLBAR_DEV_SERVERenv varTest plan
@tryghost/admin-toolbarappears on npmhttps://cdn.jsdelivr.net/ghost/admin-toolbar@~0.1/umd/admin-toolbar.min.js🤖 Generated with Claude Code