Skip to content

Added admin-toolbar to CI publish pipeline and release tooling#28244

Merged
ErisDS merged 1 commit into
mainfrom
fix/admin-toolbar-loading
May 29, 2026
Merged

Added admin-toolbar to CI publish pipeline and release tooling#28244
ErisDS merged 1 commit into
mainfrom
fix/admin-toolbar-loading

Conversation

@ErisDS
Copy link
Copy Markdown
Member

@ErisDS ErisDS commented May 29, 2026

Summary

  • The @tryghost/admin-toolbar package was never published to npm, so the jsDelivr CDN URL returns 404 in production — the toolbar only worked in dev mode where Docker overrides the URL to a local Vite server.
  • Added admin-toolbar to the CI build_packages and publish_packages matrices, the E2E artifact archive, version bump checks, release scripts, and devcontainer config — matching the setup of every other public app (portal, comments-ui, sodo-search, signup-form, announcement-bar).

Changes

  • .github/workflows/ci.yml — added to build_packages matrix, publish_packages matrix, and E2E tar archive
  • .github/scripts/release-apps.js — added to CONFIG_KEYS so pnpm ship works
  • .github/scripts/check-app-version-bump.js — added to MONITORED_APPS so version bumps are enforced on PRs
  • apps/admin-toolbar/package.json — added ship/preship/prepublishOnly scripts, removed src/ from published files
  • .devcontainer/compose.devcontainer.yaml — added ADMIN_TOOLBAR_DEV_SERVER env var

Test plan

  • CI passes (no runtime changes, only CI/release config)
  • After merge, verify @tryghost/admin-toolbar appears on npm
  • After npm publish, verify jsDelivr serves https://cdn.jsdelivr.net/ghost/admin-toolbar@~0.1/umd/admin-toolbar.min.js

🤖 Generated with Claude Code

The admin-toolbar package was missing from the npm publish matrix,
version bump checks, release scripts, E2E artifact archive, and
devcontainer config — so jsDelivr could never serve it in production.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Review Change Stack

Walkthrough

This PR integrates the @tryghost/admin-toolbar app into Ghost's monorepo build, test, and release infrastructure. The changes register admin-toolbar in version-bump checking, CI/CD workflows (E2E image generation, build matrix, and npm publishing), and configure the npm package to exclude source files and include lifecycle scripts for the release process. A development environment variable is added to route admin-toolbar requests to the correct dev server port.

Possibly related PRs

  • TryGhost/Ghost#27865: Also modifies .github/scripts/check-app-version-bump.js to adjust MONITORED_APPS configuration and version-bump verification logic.

Suggested reviewers

  • allouis
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and directly summarizes the main change: adding admin-toolbar to CI/release pipeline, which matches the core objective of enabling npm publication.
Description check ✅ Passed The description provides relevant context about the problem (package never published), the solution (add to CI/release tooling), detailed file changes, and a test plan—all directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/admin-toolbar-loading

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/admin-toolbar/package.json`:
- Line 26: The "ship" npm script currently runs the release script with "node
..." and must be prefixed with pnpm to follow repo policy; update the "ship"
script value (the "ship" key in package.json) to invoke the release script via
pnpm (i.e., replace the current command "node
../../.github/scripts/release-apps.js" with the same invocation prefixed by
"pnpm") so the workspace uses pnpm for running the script.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 514801ee-812a-48d9-bc64-373c1ef054bd

📥 Commits

Reviewing files that changed from the base of the PR and between 1285df1 and 90b9f59.

📒 Files selected for processing (5)
  • .devcontainer/compose.devcontainer.yaml
  • .github/scripts/check-app-version-bump.js
  • .github/scripts/release-apps.js
  • .github/workflows/ci.yml
  • apps/admin-toolbar/package.json

Comment thread apps/admin-toolbar/package.json
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.62%. Comparing base (1285df1) to head (90b9f59).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #28244   +/-   ##
=======================================
  Coverage   73.62%   73.62%           
=======================================
  Files        1537     1537           
  Lines      130819   130819           
  Branches    15655    15654    -1     
=======================================
+ Hits        96320    96322    +2     
- Misses      33508    33531   +23     
+ Partials      991      966   -25     
Flag Coverage Δ
admin-tests 54.20% <ø> (+0.02%) ⬆️
e2e-tests 73.62% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ErisDS ErisDS merged commit 14f0d5b into main May 29, 2026
55 checks passed
@ErisDS ErisDS deleted the fix/admin-toolbar-loading branch May 29, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant