Added translation for donation Stripe Checkout product title#28246
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (65)
✅ Files skipped from review due to trivial changes (26)
🚧 Files skipped from review as they are similar to previous changes (19)
WalkthroughPaymentsService now imports the i18n helper and builds the donation Stripe nickname with t('Support {siteTitle}', {siteTitle: this.settingsCache.get('title'), interpolation: {escapeValue: false}}) and truncates to 250 chars. Tests initialize and re-require i18n to verify localization, no HTML-escaping of site title, and truncation. The i18n dataset and context received a new "Support {siteTitle}" key across locale files (French: "Soutenir {siteTitle}", others added with empty values). Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🌐 Automated translation review
Verdict: ⏭️ Skipped — PR is too large for automated review
Reviewed 0 translations across 61 files.
This PR touches 61 translation files, which is beyond the automated reviewer's per-PR limit (max 15 files / 500 lines). A maintainer should review the translations manually.
Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.
ref TryGhost#28226 - translating "Support" alone and concatenating the title stops translators reordering words around the site name; the whole phrase now lives in one key ("Support {siteTitle}") - disabled HTML escaping on the interpolated title to match other siteTitle usages, so ampersands etc. stay intact in the Stripe nickname - added unit coverage for getDonationPriceNickname (English, French, no-escape, truncation)
There was a problem hiding this comment.
🌐 Automated translation review
Verdict: ⏭️ Skipped — PR is too large for automated review
Reviewed 0 translations across 61 files.
This PR touches 61 translation files, which is beyond the automated reviewer's per-PR limit (max 15 files / 500 lines). A maintainer should review the translations manually.
Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.
There was a problem hiding this comment.
🌐 Automated translation review
Verdict: ⏭️ Skipped — PR is too large for automated review
Reviewed 0 translations across 61 files.
This PR touches 61 translation files, which is beyond the automated reviewer's per-PR limit (max 15 files / 500 lines). A maintainer should review the translations manually.
Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.
|
@lujuldotcom Thanks for the contribution! I made an adjustment to allow for reversing of the token placement, added some test coverage, and rebased to avoid some of the i18n conflicts that were a result of other contributions to main. |
2 participants
Closes #28226
Localized the Stripe product title used for tips and donations. For example, French sites now show:
Soutenir [SITE TITLE]instead of:
Support [SITE TITLE]