Skip to content

Removed theme editor review modal#28250

Merged
ErisDS merged 2 commits into
mainfrom
theme-editor
May 29, 2026
Merged

Removed theme editor review modal#28250
ErisDS merged 2 commits into
mainfrom
theme-editor

Conversation

@ErisDS
Copy link
Copy Markdown
Member

@ErisDS ErisDS commented May 29, 2026

Summary

  • Removes the theme editor’s hidden review modal and the click path that opened it.
  • Keeps the modified-files count visible as a passive toolbar pill.
  • Keeps the editor focused on small, quick theme changes rather than developer-oriented review workflows.

Context

The theme editor is intended for users who need to make small, quick changes to
their theme, not as a full developer workflow. The review modal was easy to miss
and added a lot of hidden complexity to a feature we want to keep simple for now.

Users can still see when files have been modified, and can still revert changes
from the editor surface. This only removes the separate “review all changes” modal.

Testing

  • pnpm --filter @tryghost/admin-x-settings lint:js
  • pnpm --filter @tryghost/admin-x-settings build
  • pnpm --filter @tryghost/admin-x-settings test:acceptance test/acceptance/site/theme.test.ts -g "Loads CodeMirror|Confirms before discarding"

Keeps the modified-files indicator visible as a passive toolbar pill while removing the inherited review modal flow. The editor already exposes file status and revert controls inline, so the extra modal created an unwanted duplicate review surface.

Also declares the admin-x-settings dev dependencies needed by the local lint and build pipeline.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Review Change Stack

Walkthrough

This PR removes the theme review modal feature from the admin settings theme editor. The changes include: deleting the ThemeReviewModal component file (175 lines), removing its imports and integration points from ThemeCodeEditorModal, updating ThemeEditorToolbar to remove the onOpenReview callback and convert the "files modified" count from a clickable button to a non-interactive status pill with number formatting, removing the unused iconButtonClass export, and updating workspace dependencies to add TypeScript ESLint support and postcss-import.

Possibly related PRs

  • TryGhost/Ghost#27656: Main PR that originally introduced the theme review modal and toolbar wiring that is being removed in this PR.

Suggested reviewers

  • EvanHahn
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Removed theme editor review modal' clearly and specifically summarizes the main change in the changeset, accurately reflecting the primary modification across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description is directly related to the changeset, clearly explaining the removal of the theme editor review modal while retaining the modified-files count.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch theme-editor

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.62%. Comparing base (6fcbe6d) to head (7844ad0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #28250      +/-   ##
==========================================
- Coverage   73.63%   73.62%   -0.01%     
==========================================
  Files        1537     1537              
  Lines      130819   130819              
  Branches    15655    15654       -1     
==========================================
- Hits        96327    96322       -5     
+ Misses      33527    33508      -19     
- Partials      965      989      +24     
Flag Coverage Δ
admin-tests 54.20% <ø> (ø)
e2e-tests 73.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Restores the package manifests and lockfile after confirming the admin-x-settings lint and build scripts pass on a clean main checkout without declaring additional direct dependencies.
@ErisDS ErisDS merged commit e3984b9 into main May 29, 2026
48 checks passed
@ErisDS ErisDS deleted the theme-editor branch May 29, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant