Removed theme editor review modal#28250
Conversation
Keeps the modified-files indicator visible as a passive toolbar pill while removing the inherited review modal flow. The editor already exposes file status and revert controls inline, so the extra modal created an unwanted duplicate review surface. Also declares the admin-x-settings dev dependencies needed by the local lint and build pipeline.
WalkthroughThis PR removes the theme review modal feature from the admin settings theme editor. The changes include: deleting the Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28250 +/- ##
==========================================
- Coverage 73.63% 73.62% -0.01%
==========================================
Files 1537 1537
Lines 130819 130819
Branches 15655 15654 -1
==========================================
- Hits 96327 96322 -5
+ Misses 33527 33508 -19
- Partials 965 989 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Restores the package manifests and lockfile after confirming the admin-x-settings lint and build scripts pass on a clean main checkout without declaring additional direct dependencies.
Summary
Context
The theme editor is intended for users who need to make small, quick changes to
their theme, not as a full developer workflow. The review modal was easy to miss
and added a lot of hidden complexity to a feature we want to keep simple for now.
Users can still see when files have been modified, and can still revert changes
from the editor surface. This only removes the separate “review all changes” modal.
Testing
pnpm --filter @tryghost/admin-x-settings lint:jspnpm --filter @tryghost/admin-x-settings buildpnpm --filter @tryghost/admin-x-settings test:acceptance test/acceptance/site/theme.test.ts -g "Loads CodeMirror|Confirms before discarding"