Skip to content

Fixed future filter date selection#28256

Merged
jonatansberg merged 1 commit into
mainfrom
ber-3691-allow-next-billing-date-filters-beyond-2026
May 29, 2026
Merged

Fixed future filter date selection#28256
jonatansberg merged 1 commit into
mainfrom
ber-3691-allow-next-billing-date-filters-beyond-2026

Conversation

@jonatansberg
Copy link
Copy Markdown
Member

@jonatansberg jonatansberg commented May 29, 2026

What changed

  • Changed the Shade filter date picker calendar caption layout from dropdown to dropdown-months.

Why

  • react-day-picker caps year dropdown navigation at the current year by default when using captionLayout="dropdown".
  • This prevented member report date filters, including next billing date filters, from selecting dates beyond 2026 through the calendar UI.

Validation

  • pnpm --filter @tryghost/shade test -- filters.test.tsx
  • pnpm --filter @tryghost/shade build

fixes https://linear.app/ghost/issue/BER-3691/allow-next-billing-date-filters-beyond-2026

DayPicker limits year dropdown navigation to the current year by default, which prevented saved member report date filters from choosing future billing dates.
@jonatansberg jonatansberg force-pushed the ber-3691-allow-next-billing-date-filters-beyond-2026 branch from 3185f2f to d0c77c0 Compare May 29, 2026 14:08
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9d92a54f-7002-4c70-beff-01275448be6d

📥 Commits

Reviewing files that changed from the base of the PR and between 6862653 and d0c77c0.

📒 Files selected for processing (1)
  • apps/shade/src/components/patterns/filters.tsx

Walkthrough

The FilterDatePicker component in apps/shade/src/components/patterns/filters.tsx is updated to pass captionLayout="dropdown-months" to its Calendar child component, replacing the previous captionLayout="dropdown" configuration. This changes how the calendar presents its month and year selection interface to users.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fixed future filter date selection' is directly related to the main change of fixing date selection beyond 2026 by updating the calendar caption layout in the filter date picker.
Description check ✅ Passed The description is well-related to the changeset, explaining what changed ('dropdown' to 'dropdown-months'), why it was necessary (year dropdown limitation), and validation steps performed.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ber-3691-allow-next-billing-date-filters-beyond-2026

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonatansberg jonatansberg changed the title [codex] Fixed future filter date selection Fixed future filter date selection May 29, 2026
@jonatansberg jonatansberg marked this pull request as ready for review May 29, 2026 14:21
@jonatansberg jonatansberg enabled auto-merge (squash) May 29, 2026 14:22
@jonatansberg jonatansberg merged commit ea6a46d into main May 29, 2026
49 checks passed
@jonatansberg jonatansberg deleted the ber-3691-allow-next-billing-date-filters-beyond-2026 branch May 29, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant