Skip to content

Fixed type for member repository subscription link#28257

Merged
EvanHahn merged 1 commit into
mainfrom
linksubscription-offerid-type
May 29, 2026
Merged

Fixed type for member repository subscription link#28257
EvanHahn merged 1 commit into
mainfrom
linksubscription-offerid-type

Conversation

@EvanHahn
Copy link
Copy Markdown
Contributor

no ref

This is a types-only change.

MemberRepository.prototype.linkSubscription takes an optional offerId option. The types incorrectly marked it required. This fixes that and makes it optional.

no ref

This is a types-only change.

`MemberRepository.prototype.linkSubscription` takes an optional
`offerId` option. The types incorrectly marked it required. This fixes
that and makes it optional.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1838c740-2343-4986-b74f-4c0c24860cd2

📥 Commits

Reviewing files that changed from the base of the PR and between 6862653 and dda4306.

📒 Files selected for processing (1)
  • ghost/core/core/server/services/members/members-api/repositories/member-repository.js

Walkthrough

This PR updates the JSDoc type contract for the linkSubscription method in the member repository. The data.offerId parameter is now documented as optional and nullable (string | null) rather than required. No runtime logic or implementation behavior changes in this diff.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the type definition for the optional offerId parameter in the member repository subscription link method.
Description check ✅ Passed The description clearly relates to the changeset by explaining that offerId was incorrectly marked as required in the types and this PR makes it optional.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch linksubscription-offerid-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn EvanHahn enabled auto-merge (squash) May 29, 2026 14:34
@EvanHahn EvanHahn merged commit 5a84731 into main May 29, 2026
50 checks passed
@EvanHahn EvanHahn deleted the linksubscription-offerid-type branch May 29, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant