Skip to content

Fixed notification +N count badge alignment in ActivityPub#28290

Merged
minimaluminium merged 1 commit into
mainfrom
ap-notification-count-alignment-fix-DES-1400
Jun 1, 2026
Merged

Fixed notification +N count badge alignment in ActivityPub#28290
minimaluminium merged 1 commit into
mainfrom
ap-notification-count-alignment-fix-DES-1400

Conversation

@minimaluminium
Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/DES-1400/notification-more-count-15-etc-alignment-is-off-in-activitypub

  • the avatar stack row stretched to full width, so the absolutely positioned +N badge anchored to the far right edge instead of the last avatar
  • added w-fit so the row shrinks to its content, letting the existing right offset land the badge on the last avatar

- the avatar stack row stretched to full width, so the absolutely positioned +N badge anchored to the far right edge instead of the last avatar
- added w-fit so the row shrinks to its content, letting the existing right offset land the badge on the last avatar
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 299071a9-988a-44cf-9cdb-5dc4182660bd

📥 Commits

Reviewing files that changed from the base of the PR and between 4c52d99 and e82761d.

📒 Files selected for processing (2)
  • apps/activitypub/package.json
  • apps/activitypub/src/views/notifications/notifications.tsx

Walkthrough

This PR bumps the @tryghost/activitypub package version from 3.1.29 to 3.1.30 in the package manifest. Additionally, the avatar-group wrapper in the notifications view is updated with a w-fit Tailwind class to constrain its width, while preserving existing flex layout properties and alignment.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing notification badge alignment in ActivityPub by constraining the avatar row width.
Description check ✅ Passed The description is directly related to the changeset, providing context about the issue, root cause, and the specific CSS fix applied.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ap-notification-count-alignment-fix-DES-1400

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@minimaluminium minimaluminium enabled auto-merge (squash) June 1, 2026 03:34
@minimaluminium minimaluminium merged commit 509e457 into main Jun 1, 2026
48 checks passed
@minimaluminium minimaluminium deleted the ap-notification-count-alignment-fix-DES-1400 branch June 1, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant