Updated framework packages#28296
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThis PR adds Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Updated Ghost to resolve the latest Framework package release.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af120dc5fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| '@tailwindcss/postcss': 4.2.2 | ||
| '@tailwindcss/vite': 4.2.2 | ||
| '@tanstack/react-query': 4.44.0 | ||
| '@tryghost/api-framework': 3.2.3 |
There was a problem hiding this comment.
Because ghost/core now resolves @tryghost/api-framework through this catalog entry, fresh pnpm install/CI installs have to fetch @tryghost/api-framework@3.2.3. I checked the public TryGhost/framework tags and jsDelivr package listing, and the available api-framework releases currently only go up to 3.0.3, so this pin makes dependency resolution fail before the app can build or test.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
What are you going on about? These packages are available on npm.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pnpm-workspace.yaml (1)
168-175: ⚡ Quick winAlign
minimumReleaseAgeExcludeentries with@tryghost/api-framework@3.2.3transitive depsIn
pnpm-workspace.yaml(minimumReleaseAgeExclude), the versions match what@tryghost/api-framework@3.2.3declares:@tryghost/debug@2.2.2,@tryghost/promise@2.2.2,@tryghost/tpl@2.2.2, and@tryghost/validator@3.1.3; and@tryghost/debug@2.2.2pulls in@tryghost/root-utils@2.2.2, so@tryghost/root-utils@2.2.2is consistent too. Since these are temporary, leave a brief reminder to drop these exclusions once the 1-day window passes.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pnpm-workspace.yaml` around lines 168 - 175, Update the minimumReleaseAgeExclude block so the package entries exactly match the transitive dependency versions pulled by `@tryghost/api-framework`@3.2.3 (keep `@tryghost/api-framework`@3.2.3, `@tryghost/debug`@2.2.2, `@tryghost/promise`@2.2.2, `@tryghost/tpl`@2.2.2, `@tryghost/validator`@3.1.3 and `@tryghost/root-utils`@2.2.2) and add a brief inline comment next to the list reminding maintainers to remove these temporary exclusions after the 1-day release window; ensure you modify the minimumReleaseAgeExclude block (the listed package entries) accordingly so they stay consistent with the api-framework transitive deps.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@pnpm-workspace.yaml`:
- Around line 168-175: Update the minimumReleaseAgeExclude block so the package
entries exactly match the transitive dependency versions pulled by
`@tryghost/api-framework`@3.2.3 (keep `@tryghost/api-framework`@3.2.3,
`@tryghost/debug`@2.2.2, `@tryghost/promise`@2.2.2, `@tryghost/tpl`@2.2.2,
`@tryghost/validator`@3.1.3 and `@tryghost/root-utils`@2.2.2) and add a brief inline
comment next to the list reminding maintainers to remove these temporary
exclusions after the 1-day release window; ensure you modify the
minimumReleaseAgeExclude block (the listed package entries) accordingly so they
stay consistent with the api-framework transitive deps.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7980f79e-867e-4a92-aba3-2e0071c4a2c0
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
ghost/core/package.jsonpnpm-workspace.yaml
jonatansberg
force-pushed
the
update-framework-packages
branch
from
af120dc to
81dc014
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28296 +/- ##
=======================================
Coverage 73.63% 73.63%
=======================================
Files 1536 1536
Lines 130809 130812 +3
Branches 15652 15655 +3
=======================================
+ Hits 96315 96328 +13
+ Misses 33529 33496 -33
- Partials 965 988 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Summary
@tryghost/api-frameworkfrom the shared catalog@tryghost/api-framework@3.2.3Testing
CI=true pnpm install --frozen-lockfile=falseon Node 22.18.0idvalidator smoke checkpnpm --dir ghost/core test:single test/unit/server/services/comments/comments-service.test.js