Skip to content

Fixed nx bump causing i18n to be a continuous dev task#28312

Merged
9larsons merged 1 commit into
mainfrom
fix-nx-i18n
Jun 2, 2026
Merged

Fixed nx bump causing i18n to be a continuous dev task#28312
9larsons merged 1 commit into
mainfrom
fix-nx-i18n

Conversation

@9larsons
Copy link
Copy Markdown
Contributor

@9larsons 9larsons commented Jun 2, 2026

ref 84fedc2

i18n inherited continuous:true and it shouldn't be a continuous task. This doesn't stop local dev, though it does eat up extra resources and look incorrect.

ref 84fedc2

i18n inherited continuous:true and it shouldn't be a continuous task. This doesn't stop local dev, though it does eat up extra resources and look incorrect.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7fb32b66-2173-4dd5-a649-bf0343bb5070

📥 Commits

Reviewing files that changed from the base of the PR and between eac5627 and 38dbf69.

📒 Files selected for processing (2)
  • ghost/i18n/package.json
  • nx.json

Walkthrough

This PR modifies Nx workspace configuration across two files. The root nx.json is updated to add analytics: false, disabling Nx's analytics collection. Simultaneously, the i18n package configuration in ghost/i18n/package.json adds a dev target setting with continuous: false. The nx.json file also receives formatting adjustments to whitespace and indentation while preserving all existing configuration values.

Possibly related PRs

  • TryGhost/Ghost#27968: Both PRs change top-level Nx configuration in nx.json to disable Nx daemon-related behavior (useDaemonProcess: false vs analogous daemon/analytics settings).
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing an nx configuration issue where i18n inherited continuous:true setting when it shouldn't.
Description check ✅ Passed The description is directly related to the changeset, explaining the context (nx bump), the problem (i18n inheriting continuous:true), and the impact (resource consumption).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-nx-i18n

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.70%. Comparing base (8ba93e3) to head (38dbf69).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #28312      +/-   ##
==========================================
+ Coverage   73.62%   73.70%   +0.07%     
==========================================
  Files        1536     1535       -1     
  Lines      130863   130745     -118     
  Branches    15654    15641      -13     
==========================================
+ Hits        96348    96361      +13     
+ Misses      33527    33395     -132     
- Partials      988      989       +1     
Flag Coverage Δ
admin-tests 54.65% <ø> (+0.44%) ⬆️
e2e-tests 73.70% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons 9larsons enabled auto-merge (squash) June 2, 2026 14:59
@9larsons 9larsons merged commit 49f693c into main Jun 2, 2026
55 checks passed
@9larsons 9larsons deleted the fix-nx-i18n branch June 2, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant