Skip to content

Converged eslint-plugin-react-hooks and catalogued the tailwindcss plugin split#28319

Merged
9larsons merged 1 commit into
mainfrom
deps/eslint-plugins-catalog
Jun 2, 2026
Merged

Converged eslint-plugin-react-hooks and catalogued the tailwindcss plugin split#28319
9larsons merged 1 commit into
mainfrom
deps/eslint-plugins-catalog

Conversation

@9larsons
Copy link
Copy Markdown
Contributor

@9larsons 9larsons commented Jun 2, 2026

Two ESLint plugins were drifting:

  • eslint-plugin-react-hooks was 5.2.0 in admin but 4.6.2 in 7 other React apps by accident. Unified everyone on 5.2.0 via the catalog. No new lint errors surface; the few exhaustive-deps warnings already exist on main under 4.6.2.
  • eslint-plugin-tailwindcss tracks the Tailwind v4/v3 lane split, so it's moved into the catalog (4.0.0-beta.0) and the tailwind3 named catalog (3.18.2) to mirror tailwindcss itself — making the split intentional rather than incidental.

pnpm lint passes (exit 0) across all affected packages.

…ugin split

- eslint-plugin-react-hooks was split 5.2.0 (admin) vs 4.6.2 (7 other React apps) by accident; unified everyone on 5.2.0 via the catalog (admin already ran it, no new lint errors surfaced and the pre-existing exhaustive-deps warnings are unchanged)
- eslint-plugin-tailwindcss tracks the Tailwind v4/v3 lane split, so moved it into the catalog (4.0.0-beta.0) and the tailwind3 named catalog (3.18.2) to mirror tailwindcss itself, making the split intentional rather than incidental
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

Walkthrough

This PR consolidates ESLint plugin dependency versioning across the Ghost monorepo by establishing shared version catalogs in pnpm-workspace.yaml. The central catalog defines versions for eslint-plugin-react-hooks, eslint-plugin-react-refresh, and eslint-plugin-tailwindcss (4.0.0-beta.0), with an additional tailwind3 variant specifying eslint-plugin-tailwindcss@3.18.2. Individual app packages then migrate from pinned versions to catalog references via catalog: or catalog:tailwind3. The activitypub package also receives a minor version bump (3.1.30 → 3.1.31), and shade's eslint-plugin-storybook is updated from a beta to stable release (10.3.5).

Possibly related PRs

  • TryGhost/Ghost#27902: Enforces strict catalog mode in pnpm configuration to ensure all dependencies use catalog references, complementing this PR's catalog setup.
  • TryGhost/Ghost#27870: Updates CI publish workflow to use pnpm publish so that catalog: references in package.json files are correctly rewritten for npm publishing.

Suggested reviewers

  • EvanHahn
  • troyciesco
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: converging eslint-plugin-react-hooks versions and cataloguing eslint-plugin-tailwindcss to reflect the Tailwind v3/v4 split.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the consolidation of ESLint plugin versions across packages and the cataloging strategy for handling Tailwind v3/v4 splits.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deps/eslint-plugins-catalog

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.70%. Comparing base (80b1fcf) to head (40bddcc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #28319      +/-   ##
==========================================
- Coverage   73.70%   73.70%   -0.01%     
==========================================
  Files        1535     1535              
  Lines      130745   130745              
  Branches    15641    15641              
==========================================
- Hits        96369    96361       -8     
+ Misses      33413    33395      -18     
- Partials      963      989      +26     
Flag Coverage Δ
admin-tests 54.65% <ø> (-0.03%) ⬇️
e2e-tests 73.70% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons 9larsons merged commit 6081172 into main Jun 2, 2026
55 checks passed
@9larsons 9larsons deleted the deps/eslint-plugins-catalog branch June 2, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant