Improve llms relation loading#28332
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughRemoved explicit withRelated: ['tags', 'authors'] from models.Post.findPage calls in fetchIndexEntries and fetchFullEntries of the LLM frontend service while keeping the same columns selection. Added unit tests that call getLlmsTxt() and getLlmsFullTxt() and assert Post.findPage is invoked twice per function with withRelated left undefined. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
9e02753 to
636e9e6
Compare
636e9e6 to
9de02b7
Compare
This short-term change removes tags and authors relation loading from llms entry queries so we can verify whether it improves latency in the wild. If that signal holds, follow-up refactors can consolidate the entry-fetching path more broadly.
9de02b7 to
fe50b60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/llms.txtand/llms-full.txtso we can verify whether it improves llms latency in the wild.tags/authorsrelation loading from the llms entry fetches.Follow-up
Testing
pnpm install --frozen-lockfilepnpm test:single test/unit/frontend/services/llms/service.test.js— 12 passingpnpm test:single test/unit/server/services/url/lazy-url-service.test.jspnpm test:single test/unit/server/services/url/lazy-find-resource.test.jspnpm lint— completed with 2 existing warnings and no errorsgit diff --check