PSM Step 1

[halfdan]

closes #3936

• Implement new PSM
• Hook up close action
• Automatically close when view is destroyed

[halfdan]

Alright - gonna say this is ready for review. I haven't touched the tests yet, but will adjust them once getting feedback to make them pass again.

[halfdan]

Tests pass now.

@PaulAdamDavis Would be great if you could check my CSS changes. Had to move the #entry-controls onto the new PSM in order for the .delete button to not show when creating a new post.

[PaulAdamDavis]

@halfdan Looks & works just fine to me. But you say "move", looks like you've just removed them though. Is that right?

[halfdan]

@PaulAdamDavis Removed the CSS yes - but the id is still used here: halfdan@6cd8e7a#diff-eb8b4e3d326cfd468351e89277b215b6R1. This can definitely be beautified :)

[ErisDS]

@PaulAdamDavis @halfdan From reading the comments, I'm not 100% sure whether this is ready to merge? Would love to get this in ;)

[PaulAdamDavis]

@ErisDS This PR gets a 👍 from me.

As @halfdan says, "This can definitely be beautified", but I think that'll be part of a larger refactor when the PSM is more complete and we have a better idea of how the code looks when it's more feature-complete.

[novaugust]

This still doesn't close when you click off the PSM? Is that no longer an issue?

[JohnONolan]

Doesn't close when clicking outside PSM - should also close on ESC

[ErisDS]

This is looking pretty good to me now - @JohnONolan @PaulAdamDavis any further comments or can we merge?

[novaugust]

Still doesn't have the close when clicking outside the menu functionality, does it?

[ErisDS]

WFM 😉

If you're using the pr testing command, you need to delete the old branch before running the command again.

[novaugust]

Nevermind then, I hadn't taken it for a spin, was just looking for it in the code =)

[novaugust]

Ahhh I see it now https://github.com/TryGhost/Ghost/pull/3965/files#diff-eb8b4e3d326cfd468351e89277b215b6R1 ^ ^

[halfdan]

It does? Try clearing your cache :-)
On 10 Sep 2014 15:38, "Matt Enlow" notifications@github.com wrote:

Still doesn't have the close when clicking outside the menu functionality,
does it?

—
Reply to this email directly or view it on GitHub
#3965 (comment).

[novaugust]

Okay, LGTM and I'm fine with it getting merged, but there is one thing I want to point out first, and would love to fix.

This has 3 separate places where the "close post settings menu" functionality is implemented.
Here, here, and here. I think that should be dried up and made the responsibility of one thing only: the PSM view. Everyone else can interact through it. Alternatively, the action can be put on the application route, since that outlet is hooked up by it. The PSM controller can then implement a needs: 'application' to grab the method.

[ErisDS]

@halfdan what was in the latest update?

[novaugust]

He cleaned up the render's controller logic for me. +1 needs DRYing further down the road, but i'll append that to the epic (done)