CHORE: ES6 Language Update - REF ISSUE # 9589 by hkd987 · Pull Request #9662 · TryGhost/Ghost

hkd987 · 2018-06-04T12:41:55Z

updated the file to use const where appropriate and using an anonymous arrow function on the exports.

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

[+] There's a clear use-case for this code change
[ https://github.com/ES6 migrations #9589 ] Commit message has a short title & references relevant issues
[true] The build will pass (run npm test)

More info can be found by clicking the "guidelines for contributing" link above.

updaed the file to use const where approiate and using an anonymous arrow function on the exports.

kirrg001 · 2018-06-04T12:48:58Z

Thanks @hkd987 for your help!

The ES6 migration is tracked here. Please do not create any more PR's because of #9589 (comment). Please get involved into #9589, otherwise multiple people will work on the same files.

hkd987 · 2018-06-04T13:08:30Z

Thanks for the heads up. I have commented and read the thread looks like no one is working on the section I started on.

Sign in to view


-module.exports = function asset(path, options) {
-    var hasMinFile = _.get(options, 'hash.hasMinFile');
+module.exports = (path, options) => {


Changed arrow function back to es5 named export.

Sign in to view

 // Returns the path to the specified asset. The ghost flag outputs the asset path for the Ghost admin
-var proxy = require('./proxy'),
+const proxy = require('./proxy'),
    _ = require('lodash'),


Was testing out something and left the console log statment in.

Should speed speed up the program.

This should allow us to only import the lodash module that we need and speeed up the loading of this file.

CHORE: ES6 Language Update

8ecc092

updaed the file to use const where approiate and using an anonymous arrow function on the exports.

hkd987 changed the title ~~CHORE: ES6 Language Update~~ CHORE: ES6 Language Update - REF ISSUE # 9589 Jun 4, 2018

hkd987 mentioned this pull request Jun 4, 2018

ES6 migrations #9589

Closed

5 tasks

kirrg001 reviewed Jun 4, 2018

View reviewed changes

kirrg001 self-assigned this Jun 4, 2018

CHORE: changed arrow function back

27e9bdc

Changed arrow function back to es5 named export.

vikaspotluri123 reviewed Jun 4, 2018

View reviewed changes

hkd987 added 3 commits June 4, 2018 10:55

CHORE: forgot to remove console log

21a26ba

Was testing out something and left the console log statment in.

CHORE: Updated lodash to use spcific module

6d513ae

Should speed speed up the program.

CHRORE: Only import the lodash module that we need

c6623c5

This should allow us to only import the lodash module that we need and speeed up the loading of this file.

kirrg001 merged commit a993994 into TryGhost:master Jun 4, 2018

hkd987 deleted the es6-asset.js branch June 4, 2018 16:35

kirrg001 mentioned this pull request Jun 6, 2018

Migrate code to ES6 syntax (apps/amp) #9667

Merged

3 tasks

uqee mentioned this pull request Jul 13, 2018

Correct promise order in RSS feed generator #9726

Merged

Uh oh!

Conversation

hkd987 commented Jun 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kirrg001 commented Jun 4, 2018

Uh oh!

hkd987 commented Jun 4, 2018

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hkd987 commented Jun 4, 2018 •

edited

Loading