Skip to content
This repository was archived by the owner on Jul 13, 2026. It is now read-only.

Fixed visibility icon showing when visibility settings disabled via cardConfig - #1806

Merged
9larsons merged 1 commit into
mainfrom
fix-none-viz
Mar 23, 2026
Merged

Fixed visibility icon showing when visibility settings disabled via cardConfig#1806
9larsons merged 1 commit into
mainfrom
fix-none-viz

Conversation

@9larsons

Copy link
Copy Markdown
Collaborator

no ref

@9larsons
9larsons enabled auto-merge (squash) March 23, 2026 19:15
@coderabbitai

coderabbitai Bot commented Mar 23, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fca952d2-02a2-471c-851c-efb758d22b24

📥 Commits

Reviewing files that changed from the base of the PR and between 3138f1e and a9a29f1.

📒 Files selected for processing (1)
  • packages/koenig-lexical/src/components/KoenigCardWrapper.jsx

Walkthrough

A conditional guard was added around the editor state read operation that computes visibility status. The VISIBILITY_SETTINGS constant is imported, and the visibility state computation now executes only when visibility settings are enabled (cardConfig?.visibilitySettings !== VISIBILITY_SETTINGS.NONE). When visibility settings are disabled, the isVisibilityActive state defaults to false without querying the editor. This optimizes the control flow by skipping unnecessary editor reads in configurations where visibility features are not active.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the visibility icon display when visibility settings are disabled via cardConfig, which directly matches the code modification.
Description check ✅ Passed The description is minimal but related to the changeset, providing a basic reference context though lacking substantial detail.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-none-viz

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons
9larsons merged commit 1707645 into main Mar 23, 2026
3 checks passed
@9larsons
9larsons deleted the fix-none-viz branch March 23, 2026 19:22
PedroMarianoAlmeida pushed a commit to PedroMarianoAlmeida/Ghost that referenced this pull request Jul 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant