Add contrast color regression coverage - #1049
Conversation
refs #1031 refs TryGhost/Ghost#27797 Covered the reported lavender, pink, and blue backgrounds plus grays surrounding the YIQ threshold without changing existing assertions.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 3060 3060
Branches 459 459
=========================================
Hits 3060 3060 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Adds five independent regression cases for
textColorForBackgroundColorfollowing #1031. This is a tests-only change: all existing assertions remain intact and no production or generated files change.Coverage
#dacafe,#ffa5b1, and#a3e6ff.#b9b9b9and#bbbbbbto cover the white/black decision immediately below and above the YIQ threshold.#ccccccRGB blue-channel regression unchanged.A deliberate check using the previous
Color.b()calculation fails four of the five added cases, confirming the new cases protect the visual correction in #1031.Validation
yarn workspace @tryghost/color-utils buildyarn workspace @tryghost/color-utils test— 16 tests passed, 100% coverageyarn test— SDK-wide lint and tests passed across all 17 projectsgit diff --checkRefs #1031 and TryGhost/Ghost#27797.