Skip to content

Fix optional dependency check for better-sqlite3#474

Merged
acburdine merged 1 commit into
masterfrom
feat/better-sqlite3
Jul 2, 2026
Merged

Fix optional dependency check for better-sqlite3#474
acburdine merged 1 commit into
masterfrom
feat/better-sqlite3

Conversation

@acburdine

Copy link
Copy Markdown
Member

once the next version of Ghost is released, this'll need to be merged in order to fix the optional dep assertion (next version of Ghost will use better-sqlite3 instead of sqlite3)

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2d7d7a02-dfeb-4647-ade3-7626a5e5f4d3

📥 Commits

Reviewing files that changed from the base of the PR and between d0339e6 and d31e721.

📒 Files selected for processing (3)
  • 6/alpine3.23/Dockerfile
  • 6/bookworm/Dockerfile
  • Dockerfile.template

Walkthrough

The build-time dependency verification commands in three Dockerfiles (alpine3.23, bookworm, and Dockerfile.template) were updated to check for better-sqlite3 instead of sqlite3. The existing check that verifies @tryghost/image-transform can transform files (and throws if sharp isn't installed) remains unchanged in all three files.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Sequence Diagram(s)

Not applicable — this change is a simple, repetitive one-line substitution across three files with no control flow changes.

Related issues: None referenced in the provided context.

Related PRs: None referenced in the provided context.

Suggested labels: dependencies, docker

Suggested reviewers: None specified.

Poem:
A rabbit hopped through Docker's den,
Swapped sqlite3 for its cousin again,
Better-sqlite3 now takes the stage,
Sharp still checks each transformed page,
Three files updated, tidy and neat—
A build-time tweak, small but complete! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: updating the optional dependency check to use better-sqlite3.
Description check ✅ Passed The description is directly related to the change and explains the Ghost dependency switch prompting this update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/better-sqlite3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@acburdine acburdine force-pushed the feat/better-sqlite3 branch from 0405449 to ea9da88 Compare June 30, 2026 17:40
@acburdine acburdine force-pushed the feat/better-sqlite3 branch from ea9da88 to d31e721 Compare July 2, 2026 12:52
@acburdine acburdine marked this pull request as ready for review July 2, 2026 12:53
@acburdine acburdine merged commit f2dcba0 into master Jul 2, 2026
6 of 7 checks passed
@acburdine acburdine deleted the feat/better-sqlite3 branch July 2, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant