Add support for sqlite3_interrupt#518
Merged
springmeyer merged 1 commit intoTryGhost:masterfrom Apr 21, 2016
Merged
Conversation
20 tasks
|
@springmeyer : my team is also interested in this feature. Do you plan to merge this PR? What is the obstacle of not merging? |
This was referenced Nov 30, 2019
|
Hi, please add this to docs API. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for sqlite3_interrupt. This makes it possible to interrupt a long running query.
I called the function synchronously instead of going through
db->Schedulebecause if it was scheduled it wouldn't be possible to interruptexec. This is because whileexecis running the work queue is not processed. Also, thesqlite3_interruptfunction doesn't do any I/O or acquire any locks, so it won't block the javascript thread.The downside of calling
sqlite3_interruptsynchronously means that it has to check whether the database is open, and has to check thatsqlite3_closeis not about to be run by another thread. Basically, ifsqlite3_interruptis called on an already closed database, then it could cause memory corruption.To avoid this, I added a
closingvariable that's set right before sending acloseto a worker thread. Theopenvariable isn't sufficient because it's only set tofalseaftersqlite3_closehas been called.