Skip to content

Add support for sqlite3_interrupt (with fixed test)#631

Merged
springmeyer merged 1 commit intoTryGhost:masterfrom
briangreenery:sqlite3-interrupt
May 15, 2016
Merged

Add support for sqlite3_interrupt (with fixed test)#631
springmeyer merged 1 commit intoTryGhost:masterfrom
briangreenery:sqlite3-interrupt

Conversation

@briangreenery
Copy link
Copy Markdown
Contributor

This reintroduces #518, fixing the test failure that caused it to be reverted in #630. The test failure was happening because the interrupt test used common table expressions, and common table expressions are not supported on older versions of sqlite. I removed the use of common table expressions in the interrupt test to fix it.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.6%) to 85.793% when pulling 434d0da on briangreenery:sqlite3-interrupt into 30ad7e5 on mapbox:master.

@springmeyer springmeyer merged commit dc076bf into TryGhost:master May 15, 2016
@briangreenery
Copy link
Copy Markdown
Contributor Author

I'm sorry this caused the build to fail again. I'm investigating this right now.

@mtgto mtgto mentioned this pull request Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants