fix(ui): bundle Windows caption icons#135
Merged
Merged
Conversation
Tryanks
marked this pull request as ready for review
July 22, 2026 09:49
Tryanks
enabled auto-merge (squash)
July 22, 2026 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
gpui-component-assetsSegoe Fluent Iconssystem-font and PUA glyph dependencyAssetsfacadeWhy
PR #133 followed the Furray implementation and used
Segoe Fluent Icons. That font ships with Windows 11 but is not included by default on Windows 10, where private-use glyphs cannot rely on normal font fallback. The existing GPUI component asset bundle already provides deterministic SVG resources for all four caption states.User impact
Caption controls now render from assets embedded in the application binary on every supported Windows version, while native
WindowControlAreahit testing, maximize/restore switching, hover states, and layout remain unchanged.Validation
cargo fmt --all -- --checkcargo test -p tcode-ui window_caption— 6 passedcargo test -p tcode-ui assets— 1 passed and loaded all four SVGscargo check -p tcodecargo check -p tcode --target x86_64-pc-windows-gnu