refactor(agent): migrate ACP adapter to agent-client-protocol 1.2#84
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #63. The 0.10 → 1.2 jump crosses ACP's protocol-v2/schema redesign; this is a structural migration of the ~2800-line adapter, not a rename pass.
Key decisions:
schema::v1wire surface (ACP's stable protocol is still v1; v2 requires an explicit unstable feature). Dropped the broadunstablefeature; retained onlyunstable_auth_methodsandunstable_end_turn_token_usage.ClientSideConnection/asyncClienttrait → 1.2Client.builder()+ typed handlers +ByteStreams; dedicatedLocalExecutorthread preserved; handler state moved toArc<Mutex<_>>for the new Send callback requirements; permissions/fs/terminal handlers spawned off the dispatch loop.session/set_config_option).SessionModelStatefixture adapted to schema 1.4's config-option equivalent, assertions kept + one added). Known edge: legacy agents exposing only the removed unstablemodelsextension (without categorized config) lose model selection — no stable RPC exists for that in 1.2.Gates: fmt / clippy -D warnings / workspace tests (agent: 116 passed incl. full ACP suite) green locally.
🤖 Generated with Claude Code