feat: expose voice input spike#58
Merged
Merged
Conversation
4e7479a to
943bca6
Compare
920c0f7 to
0324b7a
Compare
943bca6 to
9822e8e
Compare
0324b7a to
88c0283
Compare
9822e8e to
950e7b7
Compare
88c0283 to
5fdd582
Compare
Contributor
Author
|
Post-merge review pass on #58. Intent I see here:
I did not find a concrete blocking defect in the diff. The useful risk areas for the next pass are:
Validation checked:
Smallest next action: no follow-up PR needed from this review alone. If someone continues the voice work, I would start with a manual device test checklist and a small accessibility pass on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/voiceroute with a voice input spike screen.Stacked after #57. Closes #50
Validation
git diff --checkflutter test test/navigation_test.dartcould not run in this runtime becauseflutteris not installed (command not found).