Remove optional transitive dep on vue-template-compiler - #3089
Merged
Conversation
This transitive dependency is marked as optional, but pnpm installs it by default anyways. This is an old version of vue with a false-positive CVE associated with it [1]. Since we do not use Vue in this repo, we can safely remove this dependency and avoid any security-related noise that it brings our way. 1) documentationjs/documentation#1666 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This transitive dependency is marked as optional, but pnpm installs it by default anyways. This is an old version of vue with a false-positive CVE associated with it [1].
Since we do not use Vue in this repo, we can safely remove this dependency and avoid any security-related noise that it brings our way.