Move Optim support to extension #2051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
commented
Jul 25, 2023
Project.toml
Outdated
| name = "Turing" | ||
| uuid = "fce5fe82-541a-59a6-adf8-730c64b5f9a0" | ||
| version = "0.26.6" | ||
| version = "0.26.7" |
There was a problem hiding this comment.
It seems that actually the PR is breaking since Optim.optimize is not reexported automatically anymore. That is, if someone triggered Requires/the extension with import Optim it is not possible anymore to run optimize(....) - one has to run using Optim or at least using Optim: optimize explicitly-
There was a problem hiding this comment.
That's alright. I think it is better that users explicitly write Optim.optimize/using Optim: optimize
There was a problem hiding this comment.
But then we need to bump the version, no?
Pull Request Test Coverage Report for Build 5671837474
💛 - Coveralls |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2051 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 22 22
Lines 1449 1458 +9
======================================
- Misses 1449 1458 +9
☔ View full report in Codecov by Sentry. |
JaimeRZP
reviewed
Jul 26, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JaimeRZP
approved these changes
Jul 26, 2023
torfjelde
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
LGTM though it should be made breaking as you've mentioned @devmotion
Project.toml
Outdated
| name = "Turing" | ||
| uuid = "fce5fe82-541a-59a6-adf8-730c64b5f9a0" | ||
| version = "0.26.6" | ||
| version = "0.26.7" |
There was a problem hiding this comment.
But then we need to bump the version, no?
|
Thanks @devmotion! |
yebai
added a commit
that referenced
this pull request
Jul 27, 2023
* CompatHelper: bump compat for Bijectors to 0.13, (keep existing compat) * Update Project.toml * Replacement for #2039 (#2040) * Fix testset for external samplers * Update abstractmcmc.jl * Update test/contrib/inference/abstractmcmc.jl Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com> * Update test/contrib/inference/abstractmcmc.jl Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com> * Update FillArrays compat to 1.4.1 (#2035) * Update FillArrays compat to 1.4.0 * Update test compat * Try to enable ReverseDiff tests * Update Project.toml * Update Project.toml * Bump version * Revert dependencies on FillArrays (#2042) * Update Project.toml * Update Project.toml * Fix redundant definition of `getstats` (#2044) * Fix redundant definition of `getstats` * Update Inference.jl * Revert "Update Inference.jl" This reverts commit e4f51c2. * Bump version --------- Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com> * Transfer some test utility function into DynamicPPL (#2049) * Update OptimInterface.jl * Only run optimisation tests in numerical stage. * fix function lookup after moving functions --------- Co-authored-by: Xianda Sun <sunxdt@gmail.com> * Move Optim support to extension (#2051) * Move Optim support to extension * More imports * Update Project.toml --------- Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com> --------- Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org> Co-authored-by: haris organtzidis <organtzh@gmail.com> Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com> Co-authored-by: David Widmann <devmotion@users.noreply.github.com> Co-authored-by: Xianda Sun <sunxdt@gmail.com> Co-authored-by: Cameron Pfiffer <cpfiffer@gmail.com>
yebai
added a commit
that referenced
this pull request
Aug 16, 2023
* first draft * abstractcontext + tests * bug * externalsampler() in tests * Name Tupple problems * moving stuff to DynamicPPL RP * using new DynamicPPL PR * mistakenly removed line * specific constructors * no StaticMH RWMH * Bump bijectors compat (#2052) * CompatHelper: bump compat for Bijectors to 0.13, (keep existing compat) * Update Project.toml * Replacement for #2039 (#2040) * Fix testset for external samplers * Update abstractmcmc.jl * Update test/contrib/inference/abstractmcmc.jl Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com> * Update test/contrib/inference/abstractmcmc.jl Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com> * Update FillArrays compat to 1.4.1 (#2035) * Update FillArrays compat to 1.4.0 * Update test compat * Try to enable ReverseDiff tests * Update Project.toml * Update Project.toml * Bump version * Revert dependencies on FillArrays (#2042) * Update Project.toml * Update Project.toml * Fix redundant definition of `getstats` (#2044) * Fix redundant definition of `getstats` * Update Inference.jl * Revert "Update Inference.jl" This reverts commit e4f51c2. * Bump version --------- Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com> * Transfer some test utility function into DynamicPPL (#2049) * Update OptimInterface.jl * Only run optimisation tests in numerical stage. * fix function lookup after moving functions --------- Co-authored-by: Xianda Sun <sunxdt@gmail.com> * Move Optim support to extension (#2051) * Move Optim support to extension * More imports * Update Project.toml --------- Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com> --------- Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org> Co-authored-by: haris organtzidis <organtzh@gmail.com> Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com> Co-authored-by: David Widmann <devmotion@users.noreply.github.com> Co-authored-by: Xianda Sun <sunxdt@gmail.com> Co-authored-by: Cameron Pfiffer <cpfiffer@gmail.com> * Bugfixes. * Add TODO. * Update mh.jl * Update Inference.jl * Removed obsolete exports. * removed unnecessary import of extract_priors * added missing ) in MH tests * fixed incorrect referneces to AdvancedMH in tests * improve ESLogDensityFunction * remove hardcoding of SimpleVarInfo * added fixme comment * minor style changes * fixed issues with MH with RandomWalkProposal being used as an external sampler * fixed accidental typo * move definitions of unflatten for NamedTuple * improved TODO * Update Project.toml --------- Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com> Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org> Co-authored-by: haris organtzidis <organtzh@gmail.com> Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com> Co-authored-by: David Widmann <devmotion@users.noreply.github.com> Co-authored-by: Xianda Sun <sunxdt@gmail.com> Co-authored-by: Cameron Pfiffer <cpfiffer@gmail.com> Co-authored-by: Hong Ge <hg344@cam.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.