Upgrading extension support for better set/eviction triggers#138
Merged
Upgrading extension support for better set/eviction triggers#138
Conversation
The changes also lead to dropping IDisposable for IAsyncDisposable while keeping .NET Standard 2.0 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
IValueRefreshExtensionwas limited in scope and prevented the remote eviction extension for Redis from working in scenarios where it should. This refactor updates the extension interface to be used for any local changes directly through theCacheStack.This means calls to
SetAsyncandEvictAsyncnow trigger aOnCacheUpdateAsyncandOnCacheEvictAsyncmethods on the newly renamedICacheChangeExtension.Through the changes, it also seemed relevant to drop
IDisposableforIAsyncDisposablein all cases as there is a core library (Microsoft.Bcl.AsyncInterfaces) that allowsIAsyncDisposablein .NET Standard 2.0, making the whole thing easier to use and likely prevents deadlocks from the previous.Wait()calls required in disposal.Fixes #137