Conversation
eb0b94b to
0e5605b
Compare
Approximately 22% faster in benchmarking
0e5605b to
473c624
Compare
Also introduced documentation to explain the logic a bit better.
The new DateTimeProvider updates the time every second with its timer. The unit test however performs a check within that second so an update to the current "time" is required.
This helps avoid race conditions against the timer, leading to the minimum DateTime value being returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple different things here for improving performance around the current time access. This is based on the details discussed in this Tweet: https://twitter.com/Nick_Craver/status/1262045129038344192
Currently it is ~22% faster in benchmarking.