Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditorConfig for code styling #13

Closed
Turnerj opened this issue Feb 5, 2018 · 3 comments
Closed

Add EditorConfig for code styling #13

Turnerj opened this issue Feb 5, 2018 · 3 comments
Assignees
Milestone

Comments

@Turnerj
Copy link
Member

Turnerj commented Feb 5, 2018

See: https://docs.microsoft.com/en-us/visualstudio/ide/editorconfig-code-style-settings-reference

@Turnerj Turnerj added this to the Version 1 milestone Feb 5, 2018
@Turnerj Turnerj self-assigned this Feb 5, 2018
@ghost
Copy link

ghost commented Feb 7, 2018

It will be very good idea. Because my code style settings differs, and there are many problems, when i proposed pull requests earlier...

@Turnerj
Copy link
Member Author

Turnerj commented Feb 7, 2018

@rus-bit , yep, or even just between different computers I work on. People have to deal with different formatting for different projects and something like an editor config file definitely reduces the barrier for entry.

Hope to get this sorted in the next few days.

Turnerj added a commit that referenced this issue Feb 25, 2018
Added some basic rules from the Roslyn repo's .editorconfig with some minor extensions for naming conventions and spacing
@Turnerj
Copy link
Member Author

Turnerj commented Feb 25, 2018

I've added an editor config file based on the one in the Roslyn repo.

There isn't anything too crazy in it. From my experience, most of the settings are what I had when I installed VS2017 cleanly. (eg. tabs over spaces for C#, braces on new lines)

The one rule I do specify in it explicitly is in regards to casing for "Non-field Members". From various different C# projects I have seen, some have theirs as camel case and some as pascal. I've made the decision to have mine follow pascal case.

I may change and tweak this in the future but basically follow the suggestions it highlights and let it do the document formatting.

@Turnerj Turnerj closed this as completed Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant