refactor(exporters)!: drop the react-pdf math/diagram mappings - #3022
refactor(exporters)!: drop the react-pdf math/diagram mappings#3022YousefED wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe deprecated React-PDF mappings for diagram and math blocks were removed. Package exports, build entries, dependencies, examples, documentation, and end-to-end test references were updated. ChangesReact-PDF exporter removal
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes unshipped react-pdf math and diagram mappings while preserving the deprecated exporter and other export paths; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description is detailed and on-topic. It explains the rationale, lists the main changes, describes impact, and reports testing results. The Screenshots/Video section and checklist are not included, but they are non-critical for this documentation and refactoring change. ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The react-pdf exporter is deprecated and the math/diagram blocks are new - there is no installed base for their react-pdf mappings (review feedback on #2992). The exporter itself remains available unchanged during its deprecation window; math and diagram export continues through the typst/PDF, docx, odt and email mappings. Also removes the react-pdf e2e visual test (its purpose was exactly these mappings; the deprecated exporter keeps its unit snapshot tests), trims @react-pdf/math and the mapping-only dev/peer deps from math-block, diagram-block, docs, playground and the converting-blocks-to-pdf example, and gitignores the Next.js-postinstall-generated docs/AGENTS.md + docs/CLAUDE.md.
|
8795135 to
237bc25
Compare
…react-pdf-math-diagram
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/diagram-block
@blocknote/mantine
@blocknote/math-block
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
@blocknote/xl-typst-exporter
commit: |
…react-pdf-math-diagram
…locks-to-pdf slug The new exporter's example replaces the react-pdf one at interoperability/converting-blocks-to-pdf, so existing links show the current exporter instead of a deprecated one. The react-pdf example moves to converting-blocks-to-pdf-react-pdf-deprecated (linked from the docs' deprecated-exporter section). Generated names/titles and the playground registry regenerated; docs links validated.
…ged" from the title PDF/UA already implies tagged; as the canonical PDF example its title should read like what users search for. The deprecated example points to its successor by title, so its reference follows.
…react-pdf-math-diagram
Stacked on #3021. Addresses the #2992 review feedback: the react-pdf exporter is deprecated and the math/diagram blocks are new, so there is no installed base for their react-pdf mappings — they are removed before ever shipping. The react-pdf exporter itself is untouched and remains available from
@blocknote/xl-pdf-exporter/react-pdfduring its deprecation window.Removed
@blocknote/math-block/pdf-exporterand@blocknote/diagram-block/pdf-exporterentry points: mappings, tests, snapshots, packageexports, vite build entries.@react-pdf/mathand the mapping-only dev/peer deps from math-block, diagram-block, docs, playground and theconverting-blocks-to-pdfexample (which reverts to plain react-pdf over the shared test document — it contains no math/diagram blocks).Also
docs/AGENTS.md/docs/CLAUDE.md(they are not repo content — addresses the separate review note on docs/AGENTS.md).Math and diagram export continues through the typst/PDF, docx, odt and email mappings. All unit suites, lint, and the Docker e2e (email + typst + static) are green.
🤖 Generated with Claude Code
Summary by CodeRabbit
Breaking Changes
Documentation
Maintenance