Support completion LSP feature#79
Merged
Merged
Conversation
msujew
force-pushed
the
msujew/completion
branch
2 times, most recently
from
May 27, 2026 10:35
12ea928 to
429b398
Compare
spoenemann
approved these changes
May 28, 2026
spoenemann
left a comment
Member
There was a problem hiding this comment.
This is a great starting point. We can refine it over time where needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Langium-style code completion - it's a bit more structurally sound compared to Langium:
completion_genfile that helps us with some of the reflection handling. In Langium, we were able to do this inline.CompletionContributorworks similar to the common override of theCompletionProviderin Langium - specify exactly how a completion item is generated from a specific source token type and ATN state. This also works for cross references and snippets/templates.CompletionFilterthat allows more fine-grained control over whichSymbolDescriptionelements are returned as part of the cross-reference completion logic. Acts similar to the existingLanguageScopeProvider.This is quite an extensive change, but it's also extensively tested. Also fixes a bunch of bugs in the error recovery, mostly related to
nilhandling at EOF.