test(reports): keep fixture summaries off the real job page - #1050
Merged
Conversation
The gha-annotations acceptance runs clear the top-level claim marker to test annotation output, which also un-claims the step summary: under CI they inherited the runner's real GITHUB_STEP_SUMMARY and appended their fixtures' results to the actual job page. Pin it empty wherever the marker is cleared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #1015
The #1043 step-summary auto-append is gated on the same claim marker as the stdout annotations. The gha-annotations acceptance tests clear that marker on purpose to test annotation output — which also un-claims the step summary, so under CI those six nested runs append their fixtures' failure summaries to the actual job page (141 junk lines per suite run, reproduced locally with the runner env simulated).
💡 Changes
GITHUB_STEP_SUMMARY=''in every acceptance invocation that clears_BASHUNIT_GHA_ANNOTATIONS_CLAIMED, so a run that pretends to be top-level cannot inherit the real job summary