Remove the Aegisub wrapper's ffi-experiments dependency - #22
Merged
Conversation
CoffeeFlux
marked this pull request as ready for review
September 12, 2026 00:35
Address review feedback by requiring wrapper tests on all native CI jobs and normalizing the expected Windows library path. Remove the redundant nil constructor default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubInspector's Aegisub wrapper only needed ffi-experiments for
requireffi. Replace that dependency with a localffi.loadhelper that searches the existingSubInspector/Inspector/locations under Lua/MoonScript include paths, then the system library search path. Windows, macOS, and Linux filenames are supported, and load failures retain the attempted paths and loader errors.Remove the invalid default that appended
fonts.confto the full library filename. Font configuration now defaults to the platform's normal provider; callers can still supply an explicit path.Adds tests for platform/path selection, missing libraries, DependencyControl and standalone loading, and rendering through the real staged native library. Native macOS ARM64, Windows x64, and both Linux jobs require these tests; the Intel macOS cross build retains its C tests through Rosetta. CI tool installation lives in
tools/ci/setup-lua.pyand uses MoonScript 0.7.0.Local ARM64 rendering and wrapper tests pass, including compilation with MoonScript 0.7.0. All five hosted jobs pass, including the native LuaJIT wrapper tests and all artifact uploads.
actionlintpasses.The live feed still serves the old released wrapper, so its ffi-experiments entry must remain until the next release updates the wrapper URL/checksum and removes that dependency. This PR changes the source wrapper without prematurely changing the published feed.
The release should also bump the module version and record the dependency removal and font configuration default change in its changelog.