Shift Click can Now Move Robot#3411
Conversation
Mr-Anyone
requested review from
itsarune,
sauravbanna and
williamckha
as code owners
|
Fun fact, this also work with ai vs ai. You can play around with it and see bang bang trajectory. |
itsarune
requested review from
a team,
Andrewyx,
annieisawesome2 and
zuperzane
and removed request for
a team
| logger.warning("There are no friendly robots on the field.") | ||
| return | ||
|
|
||
| robot_id = self.friendly_robot_on_field[0] |
There was a problem hiding this comment.
maybe it should use the closest robot to the point?
There was a problem hiding this comment.
would we want to move specific robots to various points? maybe we could have a field / dropdown where we select the robot to move first, and then every shift-click after that moves that robot only
There was a problem hiding this comment.
Or you could implement as shift click to select, then click to move?
itsarune
left a comment
itsarune
left a comment
There was a problem hiding this comment.
looks good! left some nits...
New Changes
|
…er.py Co-authored-by: itsarune <42703774+itsarune@users.noreply.github.com>
GrayHoang
left a comment
GrayHoang
left a comment
There was a problem hiding this comment.
Minor grammar and writing.
| ) | ||
|
|
||
| field_test_movement_layer = gl_movement_field_test_layer.GLMovementFieldTestLayer( | ||
| "Field Test Layer", full_system_proto_unix_io |
There was a problem hiding this comment.
Would it be better to say something like field movement layer?
There was a problem hiding this comment.
I am not quite sure what to do anymore. It was original called Movement FieldTest Layer, but @itsarune suggested that it be called Field Test Layer.
tbh, I do think Field Movement Layer makes more sense that Field Test Layer.
There was a problem hiding this comment.
@potatoisagender's suggestion is good. "Field Movement Layer" is better
| ) | ||
| if closest_robot is None: | ||
| logger.warning( | ||
| "No robot founds. Are you sure there is friendly robot on field?" |
There was a problem hiding this comment.
| "No robot founds. Are you sure there is friendly robot on field?" | |
| "No robots found. Are you sure there is friendly robot on field?" |
|
@Mr-Anyone status? |
|
I did know realized I got a new round of review. |
…into move_robot_click_pr
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
GrayHoang
left a comment
GrayHoang
left a comment
There was a problem hiding this comment.
previous comment was addressed
5 participants
Description
Shift click can now move robot. You have to enable a layer on the thunderscope called
MovementFieldTestLayer.Testing Done
Tested on a field.
Resolved Issues
None
Review Checklist
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue