Visualization Proto Deduplicator#3574
Merged
Lmh-java merged 11 commits intoUBC-Thunderbots:masterfrom Mar 8, 2026
Merged
Conversation
Lmh-java
changed the title
Andrewyx
reviewed
Jan 23, 2026
src/software/thunderscope/robot_diagnostics/handheld_controller_widget.py
Show resolved
Hide resolved
Lmh-java
force-pushed
the
lmh/proto-deduper
branch
3 times, most recently
from
a08b0c2 to
29b5374
Compare
Lmh-java
force-pushed
the
lmh/proto-deduper
branch
from
1859d48 to
9c37888
Compare
Lmh-java
force-pushed
the
lmh/proto-deduper
branch
from
ea3b18e to
6fb22d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #3549
Because we are sending lots of duplicated visualization protos over the network at a very fast rate, the system network buffer is not happy with this. (Some machines will crash). This PR introduces a sliding window deduper that controls the rate of sending duplicates (with less-to-no additional overhead) to mitigate the problem.
These warnings will be gone after this PR is merged.
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue