Skip to content

Skeleton of geometry panel#56

Merged
ruaridhg merged 38 commits intomainfrom
smg/skeleton-geometry
Jun 6, 2023
Merged

Skeleton of geometry panel#56
ruaridhg merged 38 commits intomainfrom
smg/skeleton-geometry

Conversation

@sfmig
Copy link
Copy Markdown
Collaborator

@sfmig sfmig commented May 12, 2023

This PR follows the materials panel approach to create the geometry panel.

Main features

  • It adds a subpanel for each geometry node group, and populates each of them with the nodes' sockets that are candidates for randomisation.
  • The header of each subpanel is a button that shows the graph for that node group in the Geometry Node Editor.
  • The panel updates for node groups of infinite depth (i.e., node groups that are various level deep inside node groups are also considered).
  • Only the subpanels of node groups relevant to the currently active object are shown as enabled.
  • If a geometry node group is not inside another node group, and is not linked to a modifier of the currently active object, a new modifier is created and the geometry node group is linked to it

Closes #15

sfmig added 30 commits May 12, 2023 16:11
…ude relevant socket types to randomise geometry nodes
…aterial sockets if subpanel not extended by default
…ier linked to it, it creates it in order to visualise the graph
… the currently active object. add view graph for nodes nested 1 level
@sfmig sfmig marked this pull request as ready for review June 1, 2023 13:14
@sfmig sfmig requested review from ruaridhg and tdowrick June 1, 2023 13:19
@sfmig sfmig linked an issue Jun 2, 2023 that may be closed by this pull request
@sfmig sfmig removed a link to an issue Jun 2, 2023
Copy link
Copy Markdown
Collaborator

@ruaridhg ruaridhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner now and therefore easier to read!

Comment thread notebook_root_node.py Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unclear where this is used?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed! I like to add the notebooks to have them in the history but sometimes I forget to remove them

Copy link
Copy Markdown
Collaborator

@ruaridhg ruaridhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start skeleton of geometry panel

2 participants