Include recursive node groups in the materials panel#59
Merged
Conversation
… corresponding material
…table node function for shader nodes
Collaborator
|
Works well for me. Have tested with a combination of nodes at the top level, and up to 2 levels deep within groups. |
6ec0a5c to
a4688f4
Compare
Collaborator
Author
|
hi @ruaridhg, I now rebased to the end of the current main branch. Would you mind having a look now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, only node groups one level deep relative to the material were considered.
With this PR, node groups at any depth are added to the material subpanel if they have nodes to randomise inside.
Pending: adding a view graph operator at the header of each node group, to show the graph of each node group. This is implemented for the geometry nodes already and should be very similar for this case. Planning to work on it on a separate PR.
This PR closes #53