Skip to content

Include recursive node groups in the materials panel#59

Merged
ruaridhg merged 8 commits intomainfrom
smg/recursive-material-nodes
Jun 6, 2023
Merged

Include recursive node groups in the materials panel#59
ruaridhg merged 8 commits intomainfrom
smg/recursive-material-nodes

Conversation

@sfmig
Copy link
Copy Markdown
Collaborator

@sfmig sfmig commented Jun 2, 2023

Before, only node groups one level deep relative to the material were considered.

With this PR, node groups at any depth are added to the material subpanel if they have nodes to randomise inside.

Pending: adding a view graph operator at the header of each node group, to show the graph of each node group. This is implemented for the geometry nodes already and should be very similar for this case. Planning to work on it on a separate PR.

This PR closes #53

@sfmig sfmig marked this pull request as ready for review June 5, 2023 16:34
@sfmig sfmig requested review from ruaridhg and tdowrick June 5, 2023 16:34
Copy link
Copy Markdown
Collaborator

@ruaridhg ruaridhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfmig Would you be able to squash some of these commits because I feel like I'm re-reviewing the skeleton geometry panel since a lot of this includes the same changes as the PR dealt with in #56

@tdowrick
Copy link
Copy Markdown
Collaborator

tdowrick commented Jun 6, 2023

Works well for me. Have tested with a combination of nodes at the top level, and up to 2 levels deep within groups.

@sfmig sfmig force-pushed the smg/recursive-material-nodes branch from 6ec0a5c to a4688f4 Compare June 6, 2023 15:30
@sfmig
Copy link
Copy Markdown
Collaborator Author

sfmig commented Jun 6, 2023

hi @ruaridhg, I now rebased to the end of the current main branch. Would you mind having a look now?

Copy link
Copy Markdown
Collaborator

@ruaridhg ruaridhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruaridhg ruaridhg merged commit 789ef7b into main Jun 6, 2023
@ruaridhg ruaridhg deleted the smg/recursive-material-nodes branch June 6, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recursive node groups in the materials panel

3 participants