Skip to content

RunTests::check_if_equal unsafe for floats/double #183

Description

@KrisThielemans

current code uses

((fabs(b)>tolerance && fabs(a/b-1) > tolerance)
      || (fabs(b)<=tolerance && fabs(a-b) > tolerance))

However, this fails if tolerance is large, e.g. for large magnitude numbers, as fabs(a/b/-1) should always be small.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions