test(cli): Derive cache clean test path from CACHE_VERSION - #1495
Merged
Conversation
Export CACHE_VERSION from CacheManager and build the test's buildCache path from it, so the mocked test stays in sync when the version is bumped.
RandomByte
marked this pull request as ready for review
August 3, 2026 09:43
matz3
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test/lib/cli/commands/cache.jsfully mocksCacheManager, so the realCACHE_VERSIONnever runs. The"buildCache/v0_7"literals were self-consistent stub data: a version bump inCacheManager.jswould leave them stale without failing any assertion.Change
CACHE_VERSIONfromCacheManager.js(the./internal/build/cache/CacheManagerentry point already exists).BUILD_CACHE_PATH = `buildCache/${CACHE_VERSION}`, replacing the hardcoded literals so the test stays in sync on a version bump.The one
"buildCache/v0_6"remains literal on purpose: it simulates an older, stale cache directory distinct from the current version.